fix: replace last usages of legacy gas fee polling with polling by networkClientId

[jiexi]

Description

#23010 made initial changes to replace the GasFeeController's legacy gas fee polling in favor of polling via networkClientId. It was discovered that there are still lingering instances of the legacy gas fee polling which were causing double polling to occur since the legacy and networkClientId based polling run on separate loops. This PR fixes this by replacing those remaining legacy gas fee polling usages.

Related issues

Fixes: #23010

Manual testing steps

1. Open background console -> Network tab
2. Open Extension Popup -> send -> enter address and amount -> next
3. Background console network tab should now start showing one single network request every 10s to the gas api endpoint

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.59%. Comparing base (15fc955) to head (c7accb4).

Files	Patch %	Lines
ui/ducks/send/send.js	62.50%	3 Missing ⚠️
...saction-base/confirm-transaction-base.component.js	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24065      +/-   ##
===========================================
- Coverage    67.59%   67.59%   -0.00%     
===========================================
  Files         1250     1250              
  Lines        48987    49005      +18     
  Branches     12792    12802      +10     
===========================================
+ Hits         33110    33122      +12     
- Misses       15877    15883       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BelfordZ]

smell ya later, old polling!

[metamaskbot]

Builds ready [a8d0d2f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1296 ± 645 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	340	133	73	35
		domContentLoaded	11	71	28	14	7
		load	66	2909	1296	1343	645
		domInteractive	11	71	28	14	7

Bundle size diffs [🚀 Bundle size reduced!]

• background: -214 Bytes (-0.01%)
• ui: 145 Bytes (0.00%)
• common: -203 Bytes (-0.00%)

[adonesky1]

LGTM!

[jpuri]

I reviewed all confirmation components related code and it looks good 👍

[metamaskbot]

Builds ready [cc492cb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1327 ± 661 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	393	151	92	44
		domContentLoaded	10	70	32	17	8
		load	61	3133	1327	1377	661
		domInteractive	10	70	32	17	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: -214 Bytes (-0.01%)
• ui: 145 Bytes (0.00%)
• common: -203 Bytes (-0.00%)

[adonesky1]

Wait actually I might be seeing an issue where polling continues after the send flow is closed.

Ok nevermind was a fluke. This appears to be working as expected!

[metamaskbot]

Builds ready [c7accb4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2303 ± 547 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	384	152	79	38
		domContentLoaded	10	83	33	20	10
		load	59	3653	2303	1140	547
		domInteractive	10	83	33	20	10

Bundle size diffs [🚀 Bundle size reduced!]

• background: -214 Bytes (-0.01%)
• ui: 145 Bytes (0.00%)
• common: -203 Bytes (-0.00%)