Add networkClientId to DetectTokensController.detectNewTokens()

[jiexi]

Description

Currently networkClientId token based polling in the DetectTokensController does not make the getBalancesInSingleCall contract call with the provider for the networkClientId. This is because networkClientId is not being passed from _executePoll to getBalancesInSingleCall.

This PR adds an optional networkClientId param to detectNewTokens which is used to:

• make getBalancesInSingleCall calls with the correct provider
• override the chainId argument if also passed

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2097

Manual testing steps

Nothing should change as this does not affect the current single globally selected network flow and the multichain polling for this has not been integrated yet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[adonesky1]

LGTM!

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (34df597) 68.54% compared to head (2cd0d7a) 68.54%.

Files	Patch %	Lines
app/scripts/controllers/detect-tokens.js	62.50%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22898      +/-   ##
===========================================
- Coverage    68.54%   68.54%   -0.00%     
===========================================
  Files         1088     1088              
  Lines        42900    42904       +4     
  Branches     11418    11419       +1     
===========================================
+ Hits         29403    29405       +2     
- Misses       13497    13499       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [2cd0d7a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (989 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	160	348	208	40	19
		domContentLoaded	14	69	49	21	10
		load	881	1278	989	99	48
		domInteractive	14	69	49	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 47 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[adonesky1]

LGTM