chore(deps): upgrade from json-rpc-engine to @metamask/json-rpc-engine

[legobeat]

Description

Related issues

• [Bug]: CCIP Read ENS resolution fails #27784
• [bug] CCIP read is not working with a provider managed by this middleware eth-json-rpc-middleware#335
• fix: @metamask/eth-json-rpc-filters@^7.0.0->^8.0.0 #27917
• [Bug]: Support for Solidity custom error is broken #18510
• [Bug]: Jsonrpc errors get burried inside error.message string #15250
• Added MIP for fix error handling in API Responses metamask-improvement-proposals#36

Blocked by

• fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause edition) #24496

Follow-up to

• fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause edition) #24496

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 34.82143% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 65.67%. Comparing base (0dc23ab) to head (0d4602a).

Files	Patch %	Lines
ui/store/actions.ts	30.95%	29 Missing ⚠️
...method-middleware/handlers/ethereum-chain-utils.js	7.14%	13 Missing ⚠️
ui/store/institutional/institution-background.ts	0.00%	6 Missing ⚠️
shared/modules/error.ts	63.64%	4 Missing ⚠️
ui/ducks/send/helpers.js	0.00%	4 Missing ⚠️
...p/scripts/lib/createRPCMethodTrackingMiddleware.js	25.00%	3 Missing ⚠️
...onents/multichain/import-account/import-account.js	0.00%	3 Missing ⚠️
ui/ducks/send/send.js	40.00%	3 Missing ⚠️
...ontrollers/user-storage/user-storage-controller.ts	33.33%	2 Missing ⚠️
ui/pages/error/error.component.js	0.00%	2 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22875      +/-   ##
===========================================
- Coverage    65.70%   65.67%   -0.03%     
===========================================
  Files         1366     1366              
  Lines        54361    54394      +33     
  Branches     14141    14152      +11     
===========================================
+ Hits         35715    35718       +3     
- Misses       18646    18676      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[naugtur]

supply-chain wise:
nothing suspicious in policy changes, but it does reveal a lot of duplication of @metamask/utils which would be nice to address in the future.

[metamaskbot]

No release label on PR. Adding release label release-12.6.0 on PR, as PR was added to branch 12.6.0 when release was cut.