Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Update eth-snap-keyring to 2.1.1 #22330

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Dec 18, 2023

Description

Includes the latest fixes in the eth-snap-keyring. This blocks non permitted methods from being called by an account snap. The changes in the eth-snap-keyring can be found here.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/181
Fixes: https://github.com/MetaMask/accounts-planning/issues/121

Screenshots/Recordings

Screenshot 2023-12-18 at 3 41 18 PM Screenshot 2023-12-18 at 3 40 36 PM

Manual testing steps

  1. Go to the SSK and create an account
  2. Updated the account using this JSON, replacing the address and ID fields with the new account information, and choose one or more of the methods to remove from the list
{
    "address": "you new account address",
    "id": "your new account ID",
    "options": {},
    "methods": [
        "personal_sign",
        "eth_sign",
        "eth_signTransaction",
        "eth_signTypedData_v1",
        "eth_signTypedData_v3",
        "eth_signTypedData_v4"
    ],
    "type": "eip155:eoa"
}
  1. Navigate to the E2E Test Dapp and connect the new account
  2. Attempt to perform a method you just removed
  3. You should see a message that "Method [removed method] is not supported for account [new snap account address]"

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@owencraston owencraston requested a review from a team as a code owner December 18, 2023 20:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

k-g-j
k-g-j previously approved these changes Dec 18, 2023
k-g-j
k-g-j previously approved these changes Dec 18, 2023
@owencraston
Copy link
Contributor Author

@metamaskbot update-policies

k-g-j
k-g-j previously approved these changes Dec 18, 2023
@metamaskbot
Copy link
Collaborator

Policies updated

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bf17e3) 67.86% compared to head (5d1046f) 67.86%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22330   +/-   ##
========================================
  Coverage    67.86%   67.86%           
========================================
  Files         1068     1068           
  Lines        41300    41300           
  Branches     11080    11080           
========================================
  Hits         28028    28028           
  Misses       13272    13272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owencraston owencraston merged commit afa83da into develop Dec 19, 2023
66 of 67 checks passed
@owencraston owencraston deleted the update-eth-snap-keyring branch December 19, 2023 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Dec 19, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [5d1046f]
Page Load Metrics (1268 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint893101617235
domContentLoaded9174566732
load80222651268346166
domInteractive9174566732
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38.45 KiB (1.18%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants