-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Update eth-snap-keyring to 2.1.1 #22330
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamaskbot update-policies |
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22330 +/- ##
========================================
Coverage 67.86% 67.86%
========================================
Files 1068 1068
Lines 41300 41300
Branches 11080 11080
========================================
Hits 28028 28028
Misses 13272 13272 ☔ View full report in Codecov by Sentry. |
Builds ready [5d1046f]
Page Load Metrics (1268 ± 166 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Includes the latest fixes in the eth-snap-keyring. This blocks non permitted methods from being called by an account snap. The changes in the eth-snap-keyring can be found here.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/181
Fixes: https://github.com/MetaMask/accounts-planning/issues/121
Screenshots/Recordings
Manual testing steps
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist