Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): readable-stream@3 #21934

Merged
merged 18 commits into from
May 29, 2024
Merged

fix(deps): readable-stream@3 #21934

merged 18 commits into from
May 29, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 22, 2023 •
edited
Loading

Description

Moves to [email protected]. Remove internal use of readable-stream@2 and reduce calling to native stream APIs.

Related issues

Blocked by

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added DO-NOT-MERGE Pull requests that should not be merged dependencies Pull requests that update a dependency file team-security labels Nov 22, 2023
This was referenced Nov 22, 2023
Merged
Merged
@legobeat legobeat force-pushed the deps-readable-stream-3 branch from 114ad86 to f8a63a2 Compare November 22, 2023 11:40
@socket-security Socket Security
Copy link

socket-security bot commented Nov 22, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 30.5 kB types

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

@legobeat legobeat force-pushed the deps-readable-stream-3 branch 2 times, most recently from f95ed7f to 28915b2 Compare November 22, 2023 12:03
@socket-security Socket Security
Copy link

socket-security bot commented Nov 22, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat force-pushed the deps-readable-stream-3 branch from feadfc5 to 04540ef Compare November 22, 2023 13:48
This was referenced Nov 22, 2023
Merged
Closed
Merged
@legobeat legobeat force-pushed the deps-readable-stream-3 branch from 04540ef to 2e36cfe Compare January 15, 2024 10:17
@legobeat legobeat mentioned this pull request Jan 15, 2024
Closed
3 tasks
@legobeat legobeat mentioned this pull request Mar 11, 2024
Merged
13 tasks
@legobeat legobeat force-pushed the deps-readable-stream-3 branch 4 times, most recently from 6f2f5fc to 1054169 Compare March 11, 2024 11:49
@legobeat legobeat force-pushed the deps-readable-stream-3 branch 2 times, most recently from 6133573 to d37478f Compare April 24, 2024 20:10
@legobeat legobeat mentioned this pull request Apr 24, 2024
Merged
7 tasks
@legobeat legobeat force-pushed the deps-readable-stream-3 branch 2 times, most recently from d0dbfe4 to 32ae2ef Compare May 14, 2024 13:28
@legobeat legobeat mentioned this pull request May 14, 2024
Merged
7 tasks
@legobeat legobeat force-pushed the deps-readable-stream-3 branch 2 times, most recently from 3ee20d4 to 64deb19 Compare May 21, 2024 08:07
@legobeat legobeat requested a review from naugtur May 29, 2024 13:22
@legobeat legobeat force-pushed the deps-readable-stream-3 branch from a656e0d to 54c8c1a Compare May 29, 2024 14:03
@legobeat legobeat force-pushed the deps-readable-stream-3 branch 2 times, most recently from f14f304 to 7c52296 Compare May 29, 2024 16:53
rekmarks
rekmarks approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

legobeat and others added 18 commits May 29, 2024 17:15
@legobeat
deps: readable-stream@^2.3.3->^3.6.2
ef7dc04
@legobeat
deps: replace end-of-stream and pump with readable-stream
7919009
@legobeat
add ts-expect-error to ts-migration-dashboard
0b5b6db
@legobeat
update lavamoat polices
3b0cdd3
@legobeat
devDeps: @types/readable-stream@^2.3.15->4.0.4
69da7e3
@legobeat
chore: update lavamoat policies
16d594f
@legobeat
fix: set stream options in getNotificationTransformStream
abf8e68
@legobeat
chore: replace devDep through2 with createThroughStream util function
6e3ddf5
@legobeat
chore: convert stream-utils to cjs
04a9ed1 
to be usable from build scripts
@legobeat
chore: update lavamoat build policy
a305400
@legobeat
chore: update lavamoat policies
d6dfbaa
@legobeat
Revert "chore: update lavamoat policies"
69565a8 
This reverts commit d83e1d9.
@legobeat
Revert "chore: convert stream-utils to cjs"
e61b06f 
This reverts commit 1148c45.
@legobeat
Revert "chore: replace devDep through2 with createThroughStream util …
fa4ff23 
…function"

This reverts commit 9d15c5f.
@legobeat
chore: update lavamoat policies
6ea47cc
@legobeat
update lavamoat policies
e0ffe5d
@legobeat @rekmarks
Update development/ts-migration-dashboard/scripts/build-app.ts
e489bef 
Co-authored-by: Erik Marks <[email protected]>
@legobeat
lint:fix
ca52ccb
@legobeat legobeat force-pushed the deps-readable-stream-3 branch from 7c52296 to ca52ccb Compare May 29, 2024 17:15
@legobeat legobeat merged commit 748878f into MetaMask:develop May 29, 2024
71 of 72 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
@benjisclowder benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@rekmarks rekmarks rekmarks approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@danjm danjm Awaiting requested review from danjm

@naugtur naugtur Awaiting requested review from naugtur

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legobeat @naugtur @Mrtenz @rekmarks @benjisclowder