-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1203 - Add iframe for analytics during onboarding when participating in MetaMetrics #20693
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
2158084
to
8f3b2a8
Compare
Builds ready [8f3b2a8]
Page Load Metrics (1579 ± 38 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really cool, learned a lot!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20693 +/- ##
===========================================
+ Coverage 68.86% 68.87% +0.01%
===========================================
Files 998 998
Lines 38941 38949 +8
Branches 10465 10468 +3
===========================================
+ Hits 26816 26824 +8
Misses 12125 12125
☔ View full report in Codecov by Sentry. |
Builds ready [75879ea]
Page Load Metrics (1781 ± 66 ms)
Bundle size diffs
|
Explanation
I injected this iframe at the "Create Password" step of onboarding because it's the first common screen between Importing a Wallet and Creating a Wallet, as well as after the user has opted in or out of MetaMetrics.
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.