Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1203 - Add iframe for analytics during onboarding when participating in MetaMetrics #20693

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 1, 2023

Explanation

I injected this iframe at the "Create Password" step of onboarding because it's the first common screen between Importing a Wallet and Creating a Wallet, as well as after the user has opted in or out of MetaMetrics.

Manual Testing Steps

  1. Create a new wallet, opt into metametrics
  2. On "Create a password screen", inspect the elements to see the iframe
  3. Create another new wallet, opt out metametrics
  4. On "Create a password screen", inspect the elements to not see the iframe
  5. (Repeat these steps during import process)

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner September 1, 2023 16:57
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Sep 1, 2023
@darkwing darkwing force-pushed the 1203-analytics-iframe branch from 2158084 to 8f3b2a8 Compare September 1, 2023 17:00
@metamaskbot
Copy link
Collaborator

Builds ready [8f3b2a8]
Page Load Metrics (1579 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint111201133209
domContentLoaded1458173215788038
load1458173315798038
domInteractive1458173215788038
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 505 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, learned a lot!

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (2a32936) 68.86% compared to head (75879ea) 68.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20693      +/-   ##
===========================================
+ Coverage    68.86%   68.87%   +0.01%     
===========================================
  Files          998      998              
  Lines        38941    38949       +8     
  Branches     10465    10468       +3     
===========================================
+ Hits         26816    26824       +8     
  Misses       12125    12125              
Files Changed Coverage Δ
...onboarding-flow/create-password/create-password.js 95.88% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [75879ea]
Page Load Metrics (1781 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1162021472311
domContentLoaded14772006178013866
load14772006178113866
domInteractive14772006178013866
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 505 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 8ca1c8a into develop Sep 7, 2023
@darkwing darkwing deleted the 1203-analytics-iframe branch September 7, 2023 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
@metamaskbot metamaskbot added the release-11.2.0 Issue or pull request that will be included in release 11.2.0 label Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.2.0 Issue or pull request that will be included in release 11.2.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants