Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send message to inpage when extension revives #15958

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Send message to inpage when extension revives #15958

merged 6 commits into from
Sep 27, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 23, 2022

The PR helps fix #15052

when service worker revives and metamask controller is initialised it sends message to inpage to re-play any pending actions

@jpuri jpuri requested a review from a team as a code owner September 23, 2022 19:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8ac178b]
Page Load Metrics (2259 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90141111168
domContentLoaded2106240522338139
load2106240522597435
domInteractive2106240522338139

darkwing
darkwing previously approved these changes Sep 23, 2022
digiwand added a commit that referenced this pull request Sep 24, 2022
app/scripts/app-init.js Outdated Show resolved Hide resolved
@danjm
Copy link
Contributor

danjm commented Sep 26, 2022

@jpuri The PR description says "The PR helps fix #15052". What other changes are needed for fully fix 15052?

@jpuri
Copy link
Contributor Author

jpuri commented Sep 26, 2022

@jpuri The PR description says "The PR helps fix #15052". What other changes are needed for fully fix 15052?

@danjm : I added details here: #15052 (comment)

There are 2 other PRs that are required to be merged and then we need to update provider in extension repo to complete the task.

@metamaskbot
Copy link
Collaborator

Builds ready [c2d6952]
Page Load Metrics (2324 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91134109115
domContentLoaded19942890228816981
load20682914232416680
domInteractive19942890228816981

digiwand added a commit that referenced this pull request Sep 26, 2022
@hilvmason hilvmason added the PR - P1 identifies PRs deemed priority for Extension team label Sep 26, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [1d5d078]
Page Load Metrics (2482 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942405233499240
domContentLoaded205130892458298143
load205230992482304146
domInteractive205130892457298143

Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified w/ Chrome x macOS

@jpuri jpuri merged commit d9dda82 into develop Sep 27, 2022
@jpuri jpuri deleted the inpage_message branch September 27, 2022 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MV3: ensure that dapp requests sent during service worker restarts are properly handled
6 participants