Fix filter polling leak #1474
Merged
Fix filter polling leak #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding #1458 Uses a new streaming subprovider architecture on an experimental branch of StreamProvider: https://github.com/flyswatter/web3-stream-provider/tree/StreamSubprovider
kumavis
reviewed
May 22, 2017
app/scripts/lib/inpage-provider.js
Outdated
| const filterSubprovider = new FilterSubprovider() | ||
| engine.addProvider(filterSubprovider) | ||
|
|
||
| const stream = self.stream = new StreamSubprovider() |
There was a problem hiding this comment.
can you rename to streamProvider or something less generic
There was a problem hiding this comment.
Like RemoteStreamSubprovider? I'm not sure what you mean less generic. Isn't descriptive good here?
|
Good changes! 👍 |
kumavis
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By injecting a
FilterSubproviderinto theinpage-provider, I'm able to keep filter polling logic in-page, while keeping caching logic in our background process, so that subscriptions are deallocated when pages are closed.Fixes #1458
Required refactoring the
StreamingSubproviderto be a composableProviderEngineinstance, so that theFilterSubprovidercould be added to it.For this reason, there was a small API break in
web3-stream-providerthat needs to be merged & deployed before these tests can be rebuilt & will pass:MetaMask/web3-stream-provider#1