Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading dns-packet to ^5.2.2 to resolve vulnerability #11172

Merged
merged 1 commit into from
May 24, 2021
Merged

Upgrading dns-packet to ^5.2.2 to resolve vulnerability #11172

merged 1 commit into from
May 24, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 24, 2021

@ryanml ryanml self-assigned this May 24, 2021
@ryanml ryanml requested a review from a team as a code owner May 24, 2021 22:29
@metamaskbot
Copy link
Collaborator

Builds ready [78f5766]
Page Load Metrics (606 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45866295
domContentLoaded3967796049646
load3987806069746
domInteractive3967796049646

@danjm
Copy link
Contributor

danjm commented May 24, 2021

For the same reasons as explained in #10990, it is safe to make this 3box dependency change.

@ryanml ryanml merged commit e1c8afc into develop May 24, 2021
@ryanml ryanml deleted the dns-packet-update branch May 24, 2021 23:07
ryanml added a commit that referenced this pull request May 24, 2021
@ryanml
Upgrading dns-packet to ^5.2.2 to resolve vulnerability (#11172)
28315d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @metamaskbot @danjm