Show warnings on Add Recipient page of Send flow #10530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings were not shown on the Add Recipient page of the send flow. Now any send warnings will be shown. This can be tested using an ENS name with a confusable character in it (the confusable character warning will be shown).
A condition was also removed that prevented any warnings or errors from rendering when the user had non-zero contacts or recent addresses. I have no idea why you'd want to hide warnings or errors if the user had no contacts or recent addresses. None of these errors even pertain to contacts or recent addresses.
Manual testing steps:
faceboоk.eth
)Screenshot