Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warnings on Add Recipient page of Send flow #10530

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 27, 2021

Warnings were not shown on the Add Recipient page of the send flow. Now any send warnings will be shown. This can be tested using an ENS name with a confusable character in it (the confusable character warning will be shown).

A condition was also removed that prevented any warnings or errors from rendering when the user had non-zero contacts or recent addresses. I have no idea why you'd want to hide warnings or errors if the user had no contacts or recent addresses. None of these errors even pertain to contacts or recent addresses.

Manual testing steps:

  • Click 'Send'
  • Paste an ENS address with at least one confusable character (e.g. faceboоk.eth)
  • See that the warning is shown on the Add Recipient page
Screenshot

warning-ens

Warnings were not shown on the Add Recipient page of the send flow. Now
any send warnings will be shown. This can be tested using an ENS name
with a confusable character in it (the confusable character warning
will be shown).

A condition was also removed that prevented any warnings or errors from
rendering when the user had non-zero contacts or recent addresses. I
have no idea why you'd want to hide warnings or errors if the user had
no contacts or recent addresses. None of these errors even pertain to
contacts or recent addresses.
@Gudahtt Gudahtt force-pushed the show-warnings-on-add-recipient-page branch from 68c5c43 to fdd1400 Compare February 27, 2021 05:37
@Gudahtt Gudahtt marked this pull request as ready for review February 27, 2021 05:45
@Gudahtt Gudahtt requested a review from a team as a code owner February 27, 2021 05:45
@Gudahtt Gudahtt requested a review from shanejonas February 27, 2021 05:45
@metamaskbot
Copy link
Collaborator

Builds ready [fdd1400]
Page Load Metrics (581 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735894
domContentLoaded3567025806029
load3587045816029
domInteractive3567025796029

@Gudahtt Gudahtt merged commit 0f7e2db into develop Mar 1, 2021
@Gudahtt Gudahtt deleted the show-warnings-on-add-recipient-page branch March 1, 2021 13:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants