-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide zero balance tokens with preference #10486
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8b280da
to
3c9679d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the request here is to automatically hide tokens with zero balance?
Note that we already allow the hiding of any token manually, and we don't automatically add tokens unless we detect that a token on our list has a non-zero balance. So it seems like this would be a convenience of marginal benefit, unless I'm missing something?
Reasons I would want to be able to toggle this:
|
I see, so the main advantage for you over manually hiding tokens would be that this is temporary , and allows you to untoggle this to see your old transaction history if you want to. Does that sound about right? |
Bingo. Since we don't have a "transactions" view, thus no way to see transactions for a given token (other than telling users to go check out Etherscan) if we auto-hide zero balances, we should probably give this as an option to the user. I'm happy to hear what the rest of the team thinks though. |
I think the UX that @darkwing is proposing here is superior to other proposals we've seen that all create problems where the user can't find those tokens once they have balance in the future. @rachelcope could you take a look when you have a sec? |
Tokens.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes: #10165
I've been seeing a lot of requests for this, and I myself would love it, so I threw this together. I'm not sure if we had previous design for this so apologies if we did.