Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide zero balance tokens with preference #10486

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 22, 2021

Fixes: #10165

I've been seeing a lot of requests for this, and I myself would love it, so I threw this together. I'm not sure if we had previous design for this so apologies if we did.

@darkwing darkwing requested a review from a team as a code owner February 22, 2021 15:53
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the hide-zero-balance-tokens branch from 8b280da to 3c9679d Compare February 22, 2021 16:04
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the request here is to automatically hide tokens with zero balance?

Note that we already allow the hiding of any token manually, and we don't automatically add tokens unless we detect that a token on our list has a non-zero balance. So it seems like this would be a convenience of marginal benefit, unless I'm missing something?

@darkwing
Copy link
Contributor Author

Reasons I would want to be able to toggle this:

  1. From an investor perspective, I think it's nice to be able to show and hide tokens I have owned in the past, regardless of current balance.
  2. From an investor perspective, I would still like to see individual transaction data, regardless of if I have any balance now
  3. Automatically hiding tokens may be a bit jarring to existing users, so having this as an option would prevent UX shock. If it really does come down to users wanting that, we can simply default this to true

@Gudahtt
Copy link
Member

Gudahtt commented Feb 23, 2021

I see, so the main advantage for you over manually hiding tokens would be that this is temporary , and allows you to untoggle this to see your old transaction history if you want to. Does that sound about right?

@darkwing
Copy link
Contributor Author

Bingo. Since we don't have a "transactions" view, thus no way to see transactions for a given token (other than telling users to go check out Etherscan) if we auto-hide zero balances, we should probably give this as an option to the user. I'm happy to hear what the rest of the team thinks though.

@jacobc-eth
Copy link

I think the UX that @darkwing is proposing here is superior to other proposals we've seen that all create problems where the user can't find those tokens once they have balance in the future. @rachelcope could you take a look when you have a sec?

@darkwing
Copy link
Contributor Author

Tokens.mp4

@darkwing darkwing requested review from rachelcope and removed request for NiranjanaBinoy February 24, 2021 21:07
@darkwing
Copy link
Contributor Author

Ledger does this via a setting as well:

unnamed

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing added the needs-design Needs design support. label Mar 3, 2021
Copy link

@rachelcope rachelcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@darkwing darkwing merged commit aeffe17 into MetaMask:develop Mar 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-design Needs design support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide tokens with 0 balance
4 participants