Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed] Hide links to etherscan when no block explorer is specified for a custom network #10455

Merged
merged 3 commits into from
Feb 17, 2021
Merged

[Fixed] Hide links to etherscan when no block explorer is specified for a custom network #10455

merged 3 commits into from
Feb 17, 2021

Conversation

BboyAkers
Copy link
Contributor

Fixes: #5631

Explanation:
Once this PR is merged, etherscan-link PR, I'll update the latest version of etherscan-link in the package.json and these changes will be valid.

In these PR, if there is a custom network implemented we set the url to an empty string so it doesn't render an invalid etherscan url. We then also conditionally render the View on Etherscan text if the url is empty.

Manual testing steps:

  • Load a custom network
  • Send a transaction
  • There will be no url link to go to, thus removing the invalid etherscan url if a custom network is used

@BboyAkers BboyAkers requested a review from a team as a code owner February 16, 2021 05:06
@BboyAkers BboyAkers requested a review from darkwing February 16, 2021 05:06
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@BboyAkers BboyAkers mentioned this pull request Feb 16, 2021
Closed
@BboyAkers
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Gudahtt
Copy link
Member

Gudahtt commented Feb 16, 2021

[email protected] has been released! This PR can be updated to use that now.

These changes look good! Just need to run yarn lint:fix to fix the formatting errors.

@Gudahtt Gudahtt self-assigned this Feb 16, 2021
@BboyAkers
Copy link
Contributor Author

@Gudahtt done 🙂

@BboyAkers
Copy link
Contributor Author

@Gudahtt should I be pushing the yarn.lock?

@BboyAkers BboyAkers dismissed a stale review via 4bb0396 February 17, 2021 03:49
@BboyAkers
Copy link
Contributor Author

nvm just pushed it 🙂

@BboyAkers
Copy link
Contributor Author

@darkwing @Gudahtt Let me know what ya'll think 🙂

Gudahtt
Gudahtt approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 2122b8c into MetaMask:develop Feb 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2021
@BboyAkers BboyAkers deleted the aakers/5631 branch February 19, 2021 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@darkwing darkwing Awaiting requested review from darkwing

Assignees

@Gudahtt Gudahtt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide links to etherscan when no block explorer is specified for a custom network
2 participants
@BboyAkers @Gudahtt