Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty use of adjective instead of verb in Dutch #10448

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

actuallymentor
Copy link
Contributor

Fixes:

Faulty but very prominent Dutch spelling mistake.

Explanation

The word imported in Dutch has different forms for adjective, noun and verb usage. I removed one instance of the letter e that I noticed when using Metamask.

Line 166 might similarly be wrong, but I don't know where in the interface it is so didn't verify.

Question for devs: is the description key in English on purpose or is it use for for me to translate it?

Manual testing steps: N/A

The word `imported` in Dutch has different forms for adjective, noun and verb usage. I removed two instances of the letter `e` that I noticed when using Metamask.

Line `166` might similarly be wrong, but I don't know where in the interface it is so didn't verify.

**Question for devs:** is the `description` key in English on purpose or is it use for for me to translate it?
@actuallymentor actuallymentor requested a review from a team as a code owner February 15, 2021 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@actuallymentor
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Gudahtt
Copy link
Member

Gudahtt commented Feb 15, 2021

Thanks for the contribution!

Line 166 might similarly be wrong, but I don't know where in the interface it is so didn't verify.

The imported message on line 166 is indeed an adjective. This is shown on the account list next to imported accounts.

e.g.:
imported

@actuallymentor
Copy link
Contributor Author

I see, that is faulty usage. I added it to the PR.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Gudahtt Gudahtt merged commit 7683609 into MetaMask:develop Feb 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants