Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change copy of submit button on swaps screen #10373

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Change copy of submit button on swaps screen #10373

merged 1 commit into from
Feb 4, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 4, 2021

Adjusting the language will help us make clear to users that the swap will not take place, and that they are only going to review the order.

@danjm danjm requested a review from a team as a code owner February 4, 2021 17:35
@danjm danjm requested a review from darkwing February 4, 2021 17:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4934af7]
Page Load Metrics (875 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6210585126
domContentLoaded8279368743216
load8289398753215
domInteractive8269358733216

@danjm danjm merged commit e82ab94 into develop Feb 4, 2021
@danjm danjm deleted the adjust-get-quotes-copy branch February 4, 2021 18:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjm @metamaskbot @darkwing