Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru localized messages #10268

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Update ru localized messages #10268

merged 1 commit into from
Feb 25, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 23, 2021

These translations were provided by Lionbridge.

@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 23, 2021

This depends upon #10261

@metamaskbot
Copy link
Collaborator

Builds ready [dab2bb7]
Page Load Metrics (707 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5110269136
domContentLoaded41296870512962
load41496970712862
domInteractive41196770512962

@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 25, 2021

If any community contributors would like to help review this PR, it would be greatly appreciated!

I'll tag anyone here that has contributed in the past: @logvik @zlocate @dryajov @gornov @vcharap

I wanted to give you all the opportunity to provide feedback because we owe our current translations to you. Please don't feel obliged if you don't have the time to review, and please let me know if you'd like me to stop tagging you for reviews in the future.

Thanks!

Base automatically changed from restore-missing-locale-descriptions to develop January 26, 2021 16:59
@Gudahtt Gudahtt force-pushed the update-ru-localized-messages branch from dab2bb7 to ac14c33 Compare January 26, 2021 17:34
@metamaskbot
Copy link
Collaborator

Builds ready [ac14c33]
Page Load Metrics (601 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44735774
domContentLoaded3806575996330
load3826586016330
domInteractive3806575996330

@Gudahtt Gudahtt marked this pull request as ready for review January 26, 2021 17:51
@Gudahtt Gudahtt requested a review from a team as a code owner January 26, 2021 17:51
@Gudahtt Gudahtt requested a review from brad-decker January 26, 2021 17:51
@Gudahtt Gudahtt force-pushed the update-ru-localized-messages branch from ac14c33 to 4c51101 Compare February 2, 2021 14:48
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 2, 2021

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@metamaskbot
Copy link
Collaborator

Builds ready [4c51101]
Page Load Metrics (550 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42695273
domContentLoaded3057295497436
load3067305507436
domInteractive3057285497436

@Gudahtt Gudahtt force-pushed the update-ru-localized-messages branch from 4c51101 to 8814e8d Compare February 15, 2021 21:59
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 15, 2021

This has been rebased on develop, and the unused message swapGetQuotes has been removed.

@metamaskbot
Copy link
Collaborator

Builds ready [8814e8d]
Page Load Metrics (643 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4710962136
domContentLoaded424105864212660
load426106064312660
domInteractive423105864212660

These translations were provided by Lionbridge.
@Gudahtt Gudahtt force-pushed the update-ru-localized-messages branch from 8814e8d to 49aadbe Compare February 23, 2021 14:18
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 23, 2021

I've just rebased this again to resolve conflicts (two messages were removed)

@metamaskbot
Copy link
Collaborator

Builds ready [49aadbe]
Page Load Metrics (577 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43705984
domContentLoaded5216885754924
load5226895774924
domInteractive5216885754924

@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 25, 2021

We were unable to find reviewers for these translations, so we'll have to go without, and rely upon reports to point out any mistakes or opportunities for improvement. I've double-checked some of the more crucial messages using Google Translate.

@Gudahtt Gudahtt merged commit 1860f48 into develop Feb 25, 2021
@Gudahtt Gudahtt deleted the update-ru-localized-messages branch February 25, 2021 03:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants