Update postMessage structure for TrezorConnect 8 #10192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I tested this with MetaMask/eth-trezor-keyring#46 linked, and this works great! No warning screen, and I can even enter my passphrase on the device when using the model T. |
darkwing
force-pushed
the
fix-trezor-communication
branch
3 times, most recently
from
166be75 to
6094aae
Compare
Gudahtt
previously approved these changes
Jan 20, 2021
darkwing
force-pushed
the
fix-trezor-communication
branch
from
03083ab to
418f808
Compare
Gudahtt
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8349 , but relies on MetaMask/eth-trezor-keyring#46
Explanation:
Updating to version 8 of TrezorConnect requires an update to
eth-trezor-keyringas well as this undocumented change.Manual testing steps:
node_modulesdirectoryNote: