Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for Trezor #10131

Closed
wants to merge 2 commits into from
Closed

Update dependencies for Trezor #10131

wants to merge 2 commits into from

Conversation

snazzybytes
Copy link

Fixes: # restores ability to enter passphrase on external USB Trezor display (instead of being forced to enter it on computer's keyboard)

Explanation:
Came across this thread and I saw my friend unable to enter passphrase on his Trezor T because the UI in web browser was not giving such option.

This is my attempt to help my friends and people in the other thread and at least get the ball rolling in hopes of fixing that problem for MetaMask.

What I did:

  • updated package.json with latest trezor-connect (the EXTENDED version)
  • i rebuilt the project (new yarn.lock committed)
  • i adjusted failing unit tests that now expect new date format that includes the year (no idea how, just trying to get them to pass)

Manual testing steps:

  • to be done by MetaMask/Trezor teams

@snazzybytes snazzybytes requested a review from a team as a code owner January 2, 2021 06:28
@snazzybytes snazzybytes requested a review from darkwing January 2, 2021 06:28
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@snazzybytes
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@darkwing
Copy link
Contributor

darkwing commented Jan 6, 2021

Thank you for your submission @snazzybytes ! The update for Trezor will need to be completed at this repository:

https://github.com/MetaMask/eth-trezor-keyring

Closing and hopefully we can get this fixed over on that repository. Thank you!

@darkwing darkwing closed this Jan 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
@snazzybytes snazzybytes deleted the TrezorUpdate branch January 8, 2021 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants