Disable console in contentscript

[EtDu]

Logging in the content scripts surfaces to the external page console. SES/lockdown's logging of removals was appearing in the web console on every web page. This fix renders console useless inside of content scripts to avoid this.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8f88e2f]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (551 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	33	66	48	10	5
		domContentLoaded	345	647	550	61	29
		load	346	647	551	61	29
		domInteractive	345	646	550	61	29

[kumavis]

• contentscript lockdown logs 3x times via console.log
• console.log only is silenced to explicitly address this (ok to expand to other console methods)
• sentry console breadcrumb gathering should still work even if logging to console is ultimately disabled. they override console methods to collect breadcrumb then call original console method, our noop

[Gudahtt]

It looks like ses intentionally log this as a way to discover new APIs to add to their whitelist: https://github.com/Agoric/SES-shim/blob/1f98d31debe47a9947a5e1bfe74cc0c4b874864a/packages/ses/src/whitelist-intrinsics.js#L41 🤔 Makes sense, but I wish there was a way to disable it.

[rekmarks]

In addition to what @Gudahtt pointed out, we have a number of log statements in contentscript.js that are useful for development in particular.

I'd also hate to lose this one: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/contentscript.js/#L42

[rekmarks]

To follow up on my previous comment, if the content script blows up, the inpage script should (as of late) do enough console logging to hold us over in production.

[metamaskbot]

Builds ready [316844e]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (551 ± 25 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	69	47	11	5
		domContentLoaded	483	702	549	51	24
		load	485	706	551	51	25
		domInteractive	483	701	549	51	24

[metamaskbot]

Builds ready [31d1dbc]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (656 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	39	71	54	10	5
		domContentLoaded	543	867	655	84	40
		load	545	868	656	84	40
		domInteractive	543	867	654	84	40

[Gudahtt]

One problem discovered; looks good otherwise

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [a73b5b6]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (623 ± 26 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	37	79	52	10	5
		domContentLoaded	507	725	621	53	26
		load	509	726	623	53	26
		domInteractive	507	725	621	53	26