Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add price difference warnings to metaswap view quotes screen #9872

Closed
danjm opened this issue Nov 13, 2020 · 1 comment · Fixed by #9899
Closed

Add price difference warnings to metaswap view quotes screen #9872

danjm opened this issue Nov 13, 2020 · 1 comment · Fixed by #9899
Assignees
@darkwing
Labels
area-swaps type-enhancement
Milestone
v8.1.next?

Comments

@danjm
Copy link
Contributor

danjm commented Nov 13, 2020 •
edited
Loading

Requirements

  • Render when the price difference is about a certain percentage
  • API should be able to adjust the percentage threshold
  • Warn users if fiat value convergence rate is unavailable

Screenshot from 2020-11-13 13-34-59

https://www.figma.com/file/fDtda1cs3MmPXw1MgKswZc?embed_host=notion&kind=&node-id=1533%3A1064&viewer=1

  • view-quote.js is the root file for the screen where this feature is to be added
  • the ActionableMessage component is can be used for the warning. It will have to be extended to conditionally a InfoTooltip component to meet these designs.
  • the quote will include a "priceSlippage":{"ratio":1.0146260945475052,"calculationError":"","bucket":"low"} property that can be used to determine whether the warning message is shown. priceSlippage.ratio includes the percentage, and bucket describes the warning level
@danjm danjm added this to the v8.1.next? milestone Nov 13, 2020
@darkwing darkwing self-assigned this Nov 17, 2020
@darkwing darkwing mentioned this issue Nov 17, 2020
Merged
@Gudahtt
Copy link
Member

Gudahtt commented Nov 18, 2020

What is a "price difference"?

@danjm danjm added blocked and removed blocked labels Nov 30, 2020
darkwing added a commit that referenced this issue Dec 2, 2020
@darkwing
Fix #9872 - Show price difference warning on swaps price quote (#9899)
673371d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkwing darkwing

Labels
area-swaps type-enhancement
Projects
None yet
Milestone
v8.1.next?
Development

Successfully merging a pull request may close this issue.

Fix #9872 - Show price difference warning on swaps price quote darkwing/metamask-extension
3 participants
@darkwing @Gudahtt @danjm