Internal Txs' gas limit default overpriced for eth transfers

[tmashuang]

Describe the bug
Internal transactions, transaction initiated within MetaMask(not dapps), are defaulting to 100,000 instead of a typical 21,000.

To Reproduce (REQUIRED)
Send a Tx within MetaMask(develop) as of this issue creation and edit gas, or have advanced gas control enabled, and see the gas limit default set to 100,00 on any network.

Expected behavior
Gas limit set to typical 21,000

Screenshots

Txs' Gas Limit 100,000 Default

Browser details (please complete the following information):
VM Ubuntu 18.04
Chrome 83.0.4103.61

[tmashuang]

Seems the problem line is here

metamask-extension/ui/app/pages/send/send.utils.js

Line 210 in ddaa492

if (!sendToken && !data) {

I get sendToken = {} and data = undefined for simple send. Don't know if the sendToken param should be an object, but the solution can be simply checking if it's empty.

[Gudahtt]

Any idea how sendToken was set to an object? I'm having trouble reproducing this.

[Gudahtt]

Nevermind; I have reproduced it now. Curious - metamask.send.token is undefined, but sendToken is an empty object on that line 🤔

[Gudahtt]

It looks like this line is responsible for setting it to an empty object:

metamask-extension/ui/app/pages/send/send.component.js

Line 263 in 2873053

sendToken = {},

Even prior to #8695, selectedToken was initialized to an empty object on that line as well. But the default wasn't actually set in that case, because when no token was selected, a null was returned by the getSelectedToken selector rather than undefined. The default parameter isn't used if the parameter is null. So #8695 is responsible for this bug.