Popup may sometimes be not activating #7051
Assignees
Labels
Comments
|
possibly related: just got this failure in an e2e firefox test on circleci from an unrelated code change
|
|
From #7670
|
|
I was able to reproduce this by clicking "Connect" on the test dapp, the closing the notification window quickly while it was still loading. Subsequent notification windows would not appear. |
Closed
Merged
Gudahtt
added a commit
that referenced
this issue
Apr 9, 2020
MetaMask would sometimes get into a state where the notification popup would never open. This could happen if the notification window was closed shortly after being opened. After this happened, no popups would show up until after the extension was reset. This was happening because the background thought the popup was already open. The variable it uses to track whether the popup was open or not was being set to `true` immediately after the background asked the browser to open a new window, before a handler was attached that could respond to the window being closed. Removing this line seems to solve the problem. This line was added originally in #5437, which dealt with batch transactions. Batches of transactions seem to work just fine without this line though (from local testing), and I can't think of why this would be required. Closes #7051
Gudahtt
added a commit
that referenced
this issue
Apr 9, 2020
MetaMask would sometimes get into a state where the notification popup would never open. This could happen if the notification window was closed shortly after being opened. After this happened, no popups would show up until after the extension was reset. This was happening because the background thought the popup was already open. The variable it uses to track whether the popup was open or not was being set to `true` immediately after the background asked the browser to open a new window, before a handler was attached that could respond to the window being closed. Removing this line seems to solve the problem. This line was added originally in #5437, which dealt with batch transactions. Batches of transactions seem to work just fine without this line though (from local testing), and I can't think of why this would be required. Closes #7051
Gudahtt
added a commit
that referenced
this issue
Apr 28, 2020
This is a backport of #8314. Here's the original description: MetaMask would sometimes get into a state where the notification popup would never open. This could happen if the notification window was closed shortly after being opened. After this happened, no popups would show up until after the extension was reset. This was happening because the background thought the popup was already open. The variable it uses to track whether the popup was open or not was being set to `true` immediately after the background asked the browser to open a new window, before a handler was attached that could respond to the window being closed. Removing this line seems to solve the problem. This line was added originally in #5437, which dealt with batch transactions. Batches of transactions seem to work just fine without this line though (from local testing), and I can't think of why this would be required. Closes #7051
Gudahtt
added a commit
that referenced
this issue
Apr 29, 2020
This is a backport of #8314. Here's the original description: MetaMask would sometimes get into a state where the notification popup would never open. This could happen if the notification window was closed shortly after being opened. After this happened, no popups would show up until after the extension was reset. This was happening because the background thought the popup was already open. The variable it uses to track whether the popup was open or not was being set to `true` immediately after the background asked the browser to open a new window, before a handler was attached that could respond to the window being closed. Removing this line seems to solve the problem. This line was added originally in #5437, which dealt with batch transactions. Batches of transactions seem to work just fine without this line though (from local testing), and I can't think of why this would be required. Closes #7051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a user research session, clicking
Connectin a dapp seemed to not trigger the popup.Are there cases where the popup is not being activated? I know, this is hard to investigate without a concrete repro, but opening the issue because the OpenSea dev said they have heard of this reported by users.
It could have just been that a subsequent click hid the popup, making this part of #7022.
The text was updated successfully, but these errors were encountered: