Disallow onboarding flow in popup view #6685
Assignees
Labels
Milestone
Comments
|
hey @seandotau, thanks for flagging. We've moved to a full-screen onboarding, so I'm curious how you got to view this unstyled screen in the extension drop-down. I just tried on Brave and couldn't reproduce, curious if you're doing something particular to get to this state.
|
|
I've seen the full screen on-boarding process and it looks great. To replicate this process, I opened up Brave and the first thing I did was open remix.ethereum.org, then these un-styled screens appear. Further screenshots attached: |
bdresser
changed the title
Gudahtt
added a commit
that referenced
this issue
Aug 6, 2019
The browser behaviour when opening a new tab differs between Chrome and Firefox. In the case of a popup, Chrome will close the popup whereas Firefox will leave it open. In the case of the notification window, Chrome will move the new tab to the foreground, whereas Firefox will leave the notification window in the foreground when opening a new tab. We always want to close the current UI (popup or notification) when switching to a full-screen view. The only exception to this is when the switch is triggered from the background, which has no UI. Closes #6513, #6685
Gudahtt
added a commit
that referenced
this issue
Aug 8, 2019
* Add background environment type The `getEnvironmentType` method now checks for the background environment as well, instead of returning 'notification' for that case. Instead of adding another regex for the background path, the regexes for each environment have been replaced with the URL constructor[0]. This is the standard method of parsing URLs, and is available in all supported browsers. [0]: https://developer.mozilla.org/en-US/docs/Web/API/URL * Add note regarding a missing manifest permission The `url` parameter to `tabs.query(...)` requires the `tabs` permission, and will be ignored otherwise. We are missing this permission, so that call does not work. * Close window after opening full screen The browser behaviour when opening a new tab differs between Chrome and Firefox. In the case of a popup, Chrome will close the popup whereas Firefox will leave it open. In the case of the notification window, Chrome will move the new tab to the foreground, whereas Firefox will leave the notification window in the foreground when opening a new tab. We always want to close the current UI (popup or notification) when switching to a full-screen view. The only exception to this is when the switch is triggered from the background, which has no UI. Closes #6513, #6685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MOD EDIT
Bug: when the user installs metamask, aborts onboarding, then visits a dapp that prompts the Connect screen, the extension shows an unstyled & un-usable onboarding flow in the popup view.
Expected behavior is for MetaMask to open a full-screen onboarding flow when it receives a connect request for a non-onboarded user.
Describe the bug
Not really a bug but a usability issue. When attempting to restore a wallet, there is no check box next to "I have read the agree to the Terms of Use". The user has to actually click on the words on the sentence to make the "Import" button clickable. This is almost impossible to figure out. I discovered it by accident.
To Reproduce
Expected behavior
There should be a check box
Screenshots
If applicable, add screenshots to help explain your problem.
Browser details (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: