Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how NFTs show up in transfers #6104

Closed
aakilfernandes opened this issue Feb 3, 2019 · 2 comments
Closed

Change how NFTs show up in transfers #6104

aakilfernandes opened this issue Feb 3, 2019 · 2 comments

Comments

@aakilfernandes
Copy link

aakilfernandes commented Feb 3, 2019 •
edited
Loading

Right now Metamask display NFT transfers using '{{tokenId}} {{NFT Symbol}}'. I think it makes more sense to reverse it and use the name because right now if you're sending a cryptokitty with id of 0 it shows up as '0 CK' or whatever their symbol is. A better way would be '{{NFT name}} #{{tokenId}}' so it would show up as 'CryptoKitty #0'
@aakilfernandes
Copy link
Author

In general, symbols don't really make sense for NFTs since unlike ERC20s, no one looks at them on coinmarketcap

@aakilfernandes aakilfernandes changed the title Switch order of Token Id and NFT Symbol Change how NFTs show up in transfers Feb 3, 2019
@bdresser
Copy link
Contributor

bdresser commented Feb 4, 2019

closing in favor of #5230

@bdresser bdresser closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdresser @aakilfernandes