Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display & send individual collectibles #5230

Closed
bdresser opened this issue Sep 10, 2018 · 12 comments
Closed

Display & send individual collectibles #5230

bdresser opened this issue Sep 10, 2018 · 12 comments

Comments

@bdresser
Copy link
Contributor

bdresser commented Sep 10, 2018

@estebanmino is working on the extension's ability to pull custom images for users' collectibles / ERC 721 tokens. These need a home in the extension.

MVP idea we could keep them on the side-menu with other tokens, then display individual tokens in a scrollable list - either as vertical scroll in a tab next to History, or as a horizontal scroll where the centered icon is?

Longer-term we can consider whether the side-menu should be a feature of the home screen itself (as discussed in Slack) etc.

Collectibles will each have a "name" and an image to start.

screen shot 2018-09-10 at 4 33 33 pm

@bdresser
Copy link
Contributor Author

bdresser commented Nov 6, 2018

@estebanmino will we also support sending NFTs like any other token?

@estebanmino
Copy link
Contributor

yeah that's the idea

@bdresser
Copy link
Contributor Author

@estebanmino what data is available per token? We have an image - do we have a name or any other data?

Any other things we should be aware of as @bahnju starts thinking about design?

@estebanmino
Copy link
Contributor

estebanmino commented Dec 10, 2018

@bdresser @bahnju we have:

  • Collectible contract name
  • Collectible contract address
  • Collectible specific name
  • Collectible specific token ID
  • Collectible specific image

@bdresser
Copy link
Contributor Author

bdresser commented Jan 3, 2019

Might be worth looking at https://alphawallet.com as well!

@bdresser bdresser changed the title Display individual collectibles Display & send individual collectibles Jan 7, 2019
@bdresser
Copy link
Contributor Author

bdresser commented Jan 7, 2019

The send flow also needs to be designed for mobile. Separate but related issue MetaMask/website#282

@aakilfernandes
Copy link

aakilfernandes commented Feb 4, 2019

Hey, just wanted to pipe in here to give my thoughts since we're working on NFTs for GuildCrypt.

  1. In general, no-one knows what the symbol of NFTs are. Using the Name instead of the Symbol would be better.

  2. "1 CK" is confusing to users. Should be "CryptoKitty Test against two dapp tabs open #1"

  3. Not all NFTs implement an image. There's a Metadata standard for the URI of off-chain data, but AFAIK no standard for the form of that data (i.e. JSON, or the keys in the JSON). There's a defacto standard which is implemented by OpenSea

@bdresser
Copy link
Contributor Author

partially blocked by #5806

@bdresser
Copy link
Contributor Author

@estebanmino which GABA controller would make this possible in the extension?

@estebanmino
Copy link
Contributor

@bdresser NetworkController and PreferencesController. When we have that we could integrate assets related controllers.

@Garito
Copy link

Garito commented Mar 25, 2021

Any advance on this issue?

@danjm danjm removed blocked needs-design Needs design support. labels Dec 17, 2021
@bschorchit
Copy link

Closing this as it's fixed with NFT support on extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants