Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to all spinners #3253

Open
cjeria opened this issue Feb 15, 2018 · 3 comments
Open

Add timeout to all spinners #3253

cjeria opened this issue Feb 15, 2018 · 3 comments
Assignees
Labels
area-UI Relating to the user interface. type-enhancement ux-papercuts

Comments

@cjeria
Copy link
Contributor

cjeria commented Feb 15, 2018

I'm getting an infinite spinner after first TX screen and before the confirm screen.

See gif
infinite spinner after sending eth

@cjeria cjeria added type-bug area-UI Relating to the user interface. labels Feb 15, 2018
@cjeria
Copy link
Contributor Author

cjeria commented Feb 15, 2018

I'm forced to refresh the page. We should be timing out infinite spinners like this throughout the app, even if it's a bug that should be fixed, just leaving the user guessing is never good UX. We should contextualize and provide appropriate messaging in these cases and redirect users to try again. In this case, we should add a message like "Something went wrong" after time out and give users the option the "Try Again" and link to a new TX.

@cjeria
Copy link
Contributor Author

cjeria commented Feb 15, 2018

Suggested error message

image

@Gudahtt
Copy link
Member

Gudahtt commented Dec 4, 2020

Since this bug is rather old and didn't have reproduction steps, I've converted this issue into an "enhancement", so we can track replacing all of our spinners with spinners that timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-enhancement ux-papercuts
Projects
None yet
Development

No branches or pull requests

6 participants