Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite spinner bug #2548

Closed
danfinlay opened this issue Nov 7, 2017 · 7 comments
Closed

Fix infinite spinner bug #2548

danfinlay opened this issue Nov 7, 2017 · 7 comments

Comments

@danfinlay
Copy link
Contributor

We've had some users report issues that show Failed to fetch as an error in the background console.

Seems to suggest we may not be handling some disconnects perfectly.

@danfinlay
Copy link
Contributor Author

This issue is just for the error that's crashing our provider, causing infinite provider spinners. Can be expanded by #2552.

@Douglasacost
Copy link

in my case the issue is caused by the date configuration

@danfinlay
Copy link
Contributor Author

@Douglasacost could you clarify the date configuration diagnosis?

(Sorry for the late reply)

How do you believe a date configuration would cause this?

@Douglasacost
Copy link

@danfinlay in the server the datetime doesn't mismatch from network

@MetaMask MetaMask deleted a comment from amirsohail01 Jun 15, 2018
@bdresser
Copy link
Contributor

sorry @Douglasacost still not super clear - what server?

@whymarrh
Copy link
Contributor

I think we might be able to close this in favour or some combination of #3253 and #5210, thoughts?

@bdresser
Copy link
Contributor

Sounds good - we opened this when there were a couple live reports of this being a big issue, seems like it's quieted down. We should still implement the global timeout on spinners though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants