Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Missing Smart Transactions status page #29806

Closed
dan437 opened this issue Jan 20, 2025 · 1 comment · Fixed by #29860
Closed

[Bug]: Missing Smart Transactions status page #29806

dan437 opened this issue Jan 20, 2025 · 1 comment · Fixed by #29860
Assignees
@matthewwalsh0
Labels
regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-12.12.0 Issue or pull request that will be included in release 12.12.0 release-blocker This bug is blocking the next release rollout-blocker Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@dan437
Copy link
Contributor

dan437 commented Jan 20, 2025

Describe the bug

Have Smart Transactions enabled in Advanced Settings. When submitting a Send transaction or a dapp transaction on Ethereum mainnet, it didn't show the Smart Transactions status page. It showed the Activity list instead. A user can click on the Fox extension icon to see the status page, but it should be displayed immediately.

Expected behavior

Smart Transactions status page is displayed after submitting a Send or a dapp transaction.

Screenshots/Recordings

No response

Steps to reproduce

  1. Have Smart Transactions enabled in Advanced Settings
  2. Be on Ethereum Mainnet
  3. Try a Send or a dapp transaction
  4. You will see the Activity list instead of the status page

Error messages or log output



Detection stage


During release testing


Version


12.11.0


Build type


None


Browser


Chrome


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @dan437
dan437




            added
      

  regression-RC-12.11.0

  Regression bug that was found in release candidate (RC) for release 12.11.0

      

  team-confirmations

  Push issues to confirmations team

      

  type-bug

  Something isn't working

  labels


      Jan 20, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Jan 20, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 20, 2025

    

  



    


    

    

      
    

    


      

          @benjisclowder
benjisclowder




          added
  the 

  Sev2-normal

  Normal severity; minor loss of service or inconvenience.
 label


      Jan 21, 2025

    

  



    

    

      
    

    


      

          @jvbriones
jvbriones




          added
  the 

  release-blocker

  This bug is blocking the next release
 label


      Jan 22, 2025

    

  



    

    

      
    

    


      

          @dan437
dan437




          added
  the 

  regression-prod-12.10.1

  Regression bug that was found in production in release 12.10.1
 label


      Jan 22, 2025

    

  



    


  

  

    
  


  

      

    @matthewwalsh0
matthewwalsh0



    mentioned this issue
    
      Jan 22, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Jan 23, 2025
    
    

      


  

    

      


  

      
        @matthewwalsh0
  





      

        
          fix: missing smart transaction status confirmation (#29860)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          359f4f0
        
      

    

  

    

      
## **Description**

Ensure the smart transaction status confirmation is shown after internal
transfer transactions are confirmed.

Resolved by triggering confirmation navigation if only approval flows
exist in the state.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29860?quickstart=1)

## **Related issues**

Fixes: #29806 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Jan 23, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by team


      Jan 23, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-12.12.0

  Issue or pull request that will be included in release 12.12.0
 label


      Jan 23, 2025

    

  



  


  
    
  
  

    
  aiden069 

      pushed a commit
        to GOATNetwork/metamask-extension
      that referenced
      this issue

    
      Jan 23, 2025
    
    

      


  

    

      


  

      
        @matthewwalsh0
      
        @aiden069
  





      

        
          fix: missing smart transaction status confirmation (MetaMask#29860)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          51fb19d
        
      

    

  

    

      
## **Description**

Ensure the smart transaction status confirmation is shown after internal
transfer transactions are confirmed.

Resolved by triggering confirmation navigation if only approval flows
exist in the state.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29860?quickstart=1)

## **Related issues**

Fixes: MetaMask#29806 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




  


  
    
  
  

    
  matteoscurati 

      pushed a commit
      that referenced
      this issue

    
      Jan 27, 2025
    
    

      


  

    

      


  

      
        @matthewwalsh0
      
        @matteoscurati
  





      

        
          fix: missing smart transaction status confirmation (#29860)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          3e454bc
        
      

    

  

    

      
## **Description**

Ensure the smart transaction status confirmation is shown after internal
transfer transactions are confirmed.

Resolved by triggering confirmation navigation if only approval flows
exist in the state.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29860?quickstart=1)

## **Related issues**

Fixes: #29806 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @matthewwalsh0
  
    matthewwalsh0
    

      








      


  


  

    Labels
  



    

      

    regression-prod-12.10.1

  Regression bug that was found in production in release 12.10.1
  

    regression-RC-12.11.0

  Regression bug that was found in release candidate (RC) for release 12.11.0
  

    release-12.12.0

  Issue or pull request that will be included in release 12.12.0
  

    release-blocker

  This bug is blocking the next release
  

    rollout-blocker

  

    Sev2-normal

  Normal severity; minor loss of service or inconvenience.
  

    team-confirmations

  Push issues to confirmations team
  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: Fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: missing smart transaction status confirmation

    
      MetaMask/metamask-extension
    





    
  




      

    

  
      

  

    

      10 participants
    

    

        
          @dbrans 
        
          @jvbriones 
        
          @matthewwalsh0 
        
          @metamaskbot 
        
          @dan437 
        
          @benjisclowder 
        and others