Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: f is not a function #27454

Closed
sentry-io bot opened this issue Sep 27, 2024 · 0 comments · Fixed by #27460
Closed

TypeError: f is not a function #27454

sentry-io bot opened this issue Sep 27, 2024 · 0 comments · Fixed by #27460
Labels
area-Sentry error reporting to sentry regression-prod-12.3.0 Regression bug that was found in production in release 12.3.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug

Comments

@sentry-io
Copy link

sentry-io bot commented Sep 27, 2024

Sentry Issue: METAMASK-XC05

TypeError: f is not a function
  at <object>.onClick (ui/components/multichain/connected-accounts-menu/connected-accounts-menu.tsx:126:19)
  at obj[prop] (/metamask/scripts/sentry-install.js:24:1)
  at obj[prop] (/metamask/scripts/sentry-install.js:24:1)
  at obj[prop] (/metamask/scripts/sentry-install.js:24:1)
...
(15 additional frame(s) were not displayed)
@Gudahtt Gudahtt added type-bug regression-prod-12.3.0 Regression bug that was found in production in release 12.3.0 labels Sep 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 27, 2024
@Gudahtt Gudahtt added team-wallet-ux Sev2-normal Normal severity; minor loss of service or inconvenience. labels Sep 27, 2024
@gauthierpetetin gauthierpetetin added the area-Sentry error reporting to sentry label Sep 27, 2024
@NidhiKJha NidhiKJha mentioned this issue Sep 27, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 27, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 27, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 27, 2024
micaelae pushed a commit that referenced this issue Oct 1, 2024
@NidhiKJha @micaelae
fix: removed closeMenu for ConnectedAccountsMenu (#27460)
fb211aa 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is to remove the unused closeMenu prop from
ConnectedAccountsMenu
## **Related issues**

Fixes: #27454 

## **Manual testing steps**

1. Go to the connections page
2. click on three dot menu for connected accounts
3. everything should be working as it is

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
micaelae pushed a commit that referenced this issue Oct 1, 2024
@NidhiKJha @micaelae
fix: removed closeMenu for ConnectedAccountsMenu (#27460)
8fa460d 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is to remove the unused closeMenu prop from
ConnectedAccountsMenu
## **Related issues**

Fixes: #27454 

## **Manual testing steps**

1. Go to the connections page
2. click on three dot menu for connected accounts
3. everything should be working as it is

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
micaelae pushed a commit that referenced this issue Oct 1, 2024
@NidhiKJha @micaelae
fix: removed closeMenu for ConnectedAccountsMenu (#27460)
3c5e4c2 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is to remove the unused closeMenu prop from
ConnectedAccountsMenu
## **Related issues**

Fixes: #27454 

## **Manual testing steps**

1. Go to the connections page
2. click on three dot menu for connected accounts
3. everything should be working as it is

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
micaelae pushed a commit that referenced this issue Oct 2, 2024
@NidhiKJha @micaelae
fix: removed closeMenu for ConnectedAccountsMenu (#27460)
133c8e7 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is to remove the unused closeMenu prop from
ConnectedAccountsMenu
## **Related issues**

Fixes: #27454 

## **Manual testing steps**

1. Go to the connections page
2. click on three dot menu for connected accounts
3. everything should be working as it is

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
micaelae pushed a commit that referenced this issue Oct 2, 2024
@NidhiKJha @micaelae
fix: removed closeMenu for ConnectedAccountsMenu (#27460)
a1a5cfa 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR is to remove the unused closeMenu prop from
ConnectedAccountsMenu
## **Related issues**

Fixes: #27454 

## **Manual testing steps**

1. Go to the connections page
2. click on three dot menu for connected accounts
3. everything should be working as it is

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA
### **After**

NA
## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Sentry error reporting to sentry regression-prod-12.3.0 Regression bug that was found in production in release 12.3.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed closeMenu for ConnectedAccountsMenu MetaMask/metamask-extension
3 participants
@Gudahtt @gauthierpetetin @metamaskbot