Fix "Import flow @no-mmi Import wallet using Secret Recov..." flaky tests #27336
Assignees
Labels
flaky tests
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-extension-platform
type-bug
Comments
hjetpoluru
added
type-bug
Sev2-normal
hjetpoluru
pushed a commit
that referenced
this issue
Sep 26, 2024
…ing secret recovery phrase to recover account with non-zero balance @no-mmi`aded (#27420) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** In the process for creating a new account, we get to see this error: ``` TimeoutError: Waiting for element to be located By(css selector, [data-testid="account-list-menu-details"]) Wait timed out after 10023ms (Ran on CircleCI Node 17 of 20, Job test-e2e-chrome) at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ``` This happens after clicking the account menu, and after clicking the Add account. It seems that the click doesn't hit exactly the button due to the account list loading, making the button move. When the account list is loaded, the click is performed outside the button boundary, and this makes the popup close and you cannot find the next element: "account-list-menu-details" element. I haven't been able to reproduce this but I've seen this behaviour in the manual process [](https://codespaces.new/MetaMask/metamask-extension/pull/27420?quickstart=1) ## **Related issues** Fixes: those 3 are fixed in this PR, as they were caused by the same issue - #27419 - #27337 - #27336 ## **Manual testing steps** 1. Check ci 2. Run tests locally ## **Screenshots/Recordings** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This was referenced Sep 27, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/27420?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101671/workflows/7916cc8f-082c-4486-8cc0-36802704df43/jobs/3785883/tests
Build - Regular
Browser - Chrome
Test Scenario - Import flow @no-mmi Import wallet using Secret Recovery Phrase
Test Path - /test/e2e/tests/account/import-flow.spec.js
The text was updated successfully, but these errors were encountered: