[Bug]: Issues with contract interactions alerts #27118
Assignees
Labels
regression-RC-12.3.0
Regression bug that was found in release candidate (RC) for release 12.3.0
release-blocker
This bug is blocking the next release
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Comments
bschorchit
added
type-bug
Sev2-normal
metamaskbot
added
regression-RC-12.3
bschorchit
changed the title
bschorchit
changed the title
|
hi there @bschorchit is the alert system supposed to be in |
|
Hey @seaona, it is :) but only for signatures and for contract interactions transactions (the general confirmation, not the custom confirmations we have for specific methods) for new installs or users that go to Settings > Experimental > Improved transaction requests. |
bschorchit
added
regression-RC-12.3.0
|
thank you @bschorchit I wanted to try it out, and was getting really confused on why it didn't appear |
7 tasks
|
Fixed by #27354. |
vinistevam
added a commit
that referenced
this issue
Sep 26, 2024
…7205) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR aims to apply fixes and improvements to the Alert System in general and specific alerts such as SIWE and contract interaction. **Fixes:** 1- Display a more generic and toned-down message on the friction modal. 2- Show alerts before the Confirm Alert Modal (final friction modal) when there is a danger alert. 3- Fixed CTA button when the alert has not been acknowledged. **Fixes from UX QA feedback** [Figma](https://www.figma.com/design/gcwF9smHsgvFWQK83lT5UU/Confirmation-redesign-V4?node-id=3293-2791&t=fX0ohLSzAelDEDvM-1) - Change the Danger icon to `security-search` icon when button is `Review Alerts` or `Review Alert` - ✔️ - Remove blockaid dedicated alert modal - ✔️ - Remove the “tooltip icon” whenever an alert is present - ✔️ - Always display a critical alert first when a critical alert is present: - Inline alerts - ✔️ - Multiple Alert Modal - ✔️ - Disable the CTA "Review Alerts" whenever a blocking alert is present - ✔️ - Add "Got it" for blocking alerts. (this button will be responsible for closing the modal) - ✔️ - Remove the close `X` button - ✔️ <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/27205?quickstart=1) ## **Related issues** Fixes: #27132 #27147 #27118 ## **Manual testing steps** **Case 1** 1. Go to test dapp 2. Don't have funds 3. Trigger malicious mint erc20 on Sepolia 4. Click on Review alerts **Case 2** 1. Go to test dapp 2. Trigger malicious contract interaction on Ethereum 3. Click on Review alerts **Case 3** 1. Go to test dapp 2. Click on Sign In With Ethereum - Bad Domain 3. Click Confirm **Case 4** 1. Deploy an ERC721 contract from the test dapp 2. Trigger a transaction with a nonce +1, so it's not confirmed 3. Now trigger a Mint 4. Click on the alerts (there are 2) 5. Navigate to the 2nd alert 6. Click got it --> MM broke ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. -->  [alert-fix.webm](https://github.com/user-attachments/assets/f8d42db8-cc7d-448b-ad8f-20a789829122) [mint-without-funds.webm](https://github.com/user-attachments/assets/5e913290-79af-4432-b30a-b3a09891fba9) [Contract Interaction and Alerts.webm](https://github.com/user-attachments/assets/929a79da-eefc-44d8-b350-a165ff92300f) ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27205?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There are a few incorrect behaviors of the new alert system. More detail will be added here.
Expected behavior
Screenshots/Recordings
Untitled.mov
Steps to reproduce
Case 1
Case 2
Error messages or log output
No response
Detection stage
During release testing
Version
12.3
Build type
None
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: