Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing "X" close button in the notification #24180

Closed
hjetpoluru opened this issue Apr 22, 2024 · 2 comments
Closed

[Bug]: Missing "X" close button in the notification #24180

hjetpoluru opened this issue Apr 22, 2024 · 2 comments
Assignees
Labels
regression-prod-11.15.0 Regression bug that was found in production in release 11.15.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-swaps type-bug Something isn't working

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented Apr 22, 2024

Describe the bug

I was looking at this flaky test #1722 related to the test-e2e-chrome-vault-decryption.
CircleCI - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234

I observed that the functionality of the notification has changed, the "X" close button is no longer present, and the text has been altered as well. The changes to the notification can be found in this PR: #23155

I am uncertain whether the missing "X" functionality should be classified as a defect or if we need to update the automation script.

Note:- This test is executed only in the develop and release builds, which is why it was not reproduced in the initial PR that contained the changes.

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

Run the test-e2e-chrome-vault-decryption locally against develop build and master
yarn
yarn dist
yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome --debug --leave-running

develop-build master-build

Error messages or log output

No response

Version

11.15.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@hjetpoluru hjetpoluru added type-bug Something isn't working team-swaps regression-prod-11.0 Regression bug that was found in production in release 11.0 regression-prod-11.15.0 Regression bug that was found in production in release 11.15.0 labels Apr 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Apr 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 22, 2024
@metamaskbot metamaskbot removed the regression-prod-11.0 Regression bug that was found in production in release 11.0 label Apr 22, 2024
@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Apr 23, 2024
@forest-diggs-consensys
Copy link

Thanks for raising this - this is the expected behavior for this notification modal. The "what's new" modal behaves differently since it can contain multiple notifications/alerts.

@hjetpoluru
Copy link
Contributor Author

Thank you for clarifying the expected behavior, where the new notification will not feature an 'X' button and the user must choose between the two provided options. Also, I will update the automation test as I have already have fix with the potential options.

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Apr 23, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Apr 23, 2024
hjetpoluru added a commit that referenced this issue Apr 23, 2024
## **Description**
Change in the PR fixes the flaky test CircleCI job -
test-e2e-chrome-vault-decryption

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24195?quickstart=1)

## **Related issues**

Fixes: 
#24180
#1722

## **Manual testing steps**

Run the test in codespace or locally --> Checkout to the branch
yarn
yarn dist
yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js
--browser=chrome

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
hjetpoluru added a commit that referenced this issue Apr 23, 2024
## **Description**
Change in the PR fixes the flaky test CircleCI job -
test-e2e-chrome-vault-decryption

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24195?quickstart=1)

## **Related issues**

Fixes: 
#24180
#1722

## **Manual testing steps**

Run the test in codespace or locally --> Checkout to the branch
yarn
yarn dist
yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js
--browser=chrome

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-11.15.0 Regression bug that was found in production in release 11.15.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-swaps type-bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants