-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Missing "X" close button in the notification #24180
Comments
Thanks for raising this - this is the expected behavior for this notification modal. The "what's new" modal behaves differently since it can contain multiple notifications/alerts. |
Thank you for clarifying the expected behavior, where the new notification will not feature an 'X' button and the user must choose between the two provided options. Also, I will update the automation test as I have already have fix with the potential options. |
## **Description** Change in the PR fixes the flaky test CircleCI job - test-e2e-chrome-vault-decryption https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234 [](https://codespaces.new/MetaMask/metamask-extension/pull/24195?quickstart=1) ## **Related issues** Fixes: #24180 #1722 ## **Manual testing steps** Run the test in codespace or locally --> Checkout to the branch yarn yarn dist yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Change in the PR fixes the flaky test CircleCI job - test-e2e-chrome-vault-decryption https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234 [](https://codespaces.new/MetaMask/metamask-extension/pull/24195?quickstart=1) ## **Related issues** Fixes: #24180 #1722 ## **Manual testing steps** Run the test in codespace or locally --> Checkout to the branch yarn yarn dist yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Describe the bug
I was looking at this flaky test #1722 related to the test-e2e-chrome-vault-decryption.
CircleCI - https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/77436/workflows/983b4b1c-104a-4acc-ad35-36fe09a03a29/jobs/2685234
I observed that the functionality of the notification has changed, the "X" close button is no longer present, and the text has been altered as well. The changes to the notification can be found in this PR: #23155
I am uncertain whether the missing "X" functionality should be classified as a defect or if we need to update the automation script.
Note:- This test is executed only in the develop and release builds, which is why it was not reproduced in the initial PR that contained the changes.
Expected behavior
No response
Screenshots/Recordings
No response
Steps to reproduce
Run the test-e2e-chrome-vault-decryption locally against develop build and master
yarn
yarn dist
yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome --debug --leave-running
Error messages or log output
No response
Version
11.15.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: