Uncomment and fix all auto-fixable stylelint rules (#8989)

All stylelint rules that can be automatically fixed have been uncommented. The rules are: * `at-rule-empty-line-before` * `block-closing-brace-empty-line-before` * `block-closing-brace-newline-before` * `block-opening-brace-space-before` * `color-hex-case` * `color-hex-length` * `comment-empty-line-before` * `declaration-block-semicolon-newline-after` * `declaration-block-semicolon-space-after` * `declaration-block-trailing-semicolon` * `declaration-colon-space-after` * `declaration-empty-line-before` * `function-comma-space-after` * `function-comma-space-before` * `indentation` * `length-zero-no-unit` * `no-eol-whitespace` * `no-missing-end-of-source-newline` * `number-leading-zero` * `number-no-trailing-zeros` * `rule-empty-line-before` * `selector-list-comma-newline-after` * `selector-pseudo-element-colon-notation`
MetaMask · Jul 15, 2020 · f46dda0 · f46dda0
1 parent 8ff083b
commit f46dda0
Show file tree

Hide file tree

Showing 132 changed files with 925 additions and 944 deletions.
diff --git a/stylelint.config.js b/stylelint.config.js
@@ -1,32 +1,33 @@
 module.exports = {
   rules: {
     // stylelint-config-standard
-    // 'at-rule-empty-line-before': [
-    //   'always',
-    //   {
-    //     except: ['blockless-after-same-name-blockless', 'first-nested'],
-    //     ignore: ['after-comment'],
-    //   },
-    // ],
+
+    'at-rule-empty-line-before': [
+      'always',
+      {
+        except: ['blockless-after-same-name-blockless', 'first-nested'],
+        ignore: ['after-comment'],
+      },
+    ],
     'at-rule-name-case': 'lower',
     'at-rule-name-space-after': 'always-single-line',
     'at-rule-semicolon-newline-after': 'always',
-    // 'block-closing-brace-empty-line-before': 'never',
+    'block-closing-brace-empty-line-before': 'never',
     'block-closing-brace-newline-after': 'always',
-    // 'block-closing-brace-newline-before': 'always-multi-line',
+    'block-closing-brace-newline-before': 'always-multi-line',
     'block-closing-brace-space-before': 'always-single-line',
     'block-opening-brace-newline-after': 'always-multi-line',
     'block-opening-brace-space-after': 'always-single-line',
-    // 'block-opening-brace-space-before': 'always',
-    // 'color-hex-case': 'lower',
-    // 'color-hex-length': 'short',
-    // 'comment-empty-line-before': [
-    //   'always',
-    //   {
-    //     except: ['first-nested'],
-    //     ignore: ['stylelint-commands'],
-    //   },
-    // ],
+    'block-opening-brace-space-before': 'always',
+    'color-hex-case': 'lower',
+    'color-hex-length': 'short',
+    'comment-empty-line-before': [
+      'always',
+      {
+        except: ['first-nested'],
+        ignore: ['stylelint-commands'],
+      },
+    ],
     // 'comment-whitespace-inside': 'always',
     'custom-property-empty-line-before': [
       'always',
@@ -37,31 +38,31 @@ module.exports = {
     ],
     'declaration-bang-space-after': 'never',
     'declaration-bang-space-before': 'always',
-    // 'declaration-block-semicolon-newline-after': 'always-multi-line',
-    // 'declaration-block-semicolon-space-after': 'always-single-line',
+    'declaration-block-semicolon-newline-after': 'always-multi-line',
+    'declaration-block-semicolon-space-after': 'always-single-line',
     'declaration-block-semicolon-space-before': 'never',
     'declaration-block-single-line-max-declarations': 1,
-    // 'declaration-block-trailing-semicolon': 'always',
+    'declaration-block-trailing-semicolon': 'always',
     'declaration-colon-newline-after': 'always-multi-line',
-    // 'declaration-colon-space-after': 'always-single-line',
+    'declaration-colon-space-after': 'always-single-line',
     'declaration-colon-space-before': 'never',
-    // 'declaration-empty-line-before': [
-    //   'always',
-    //   {
-    //     except: ['after-declaration', 'first-nested'],
-    //     ignore: ['after-comment', 'inside-single-line-block'],
-    //   },
-    // ],
+    'declaration-empty-line-before': [
+      'always',
+      {
+        except: ['after-declaration', 'first-nested'],
+        ignore: ['after-comment', 'inside-single-line-block'],
+      },
+    ],
     'function-comma-newline-after': 'always-multi-line',
-    // 'function-comma-space-after': 'always-single-line',
-    // 'function-comma-space-before': 'never',
+    'function-comma-space-after': 'always-single-line',
+    'function-comma-space-before': 'never',
     'function-max-empty-lines': 0,
     'function-name-case': 'lower',
     'function-parentheses-newline-inside': 'always-multi-line',
     'function-parentheses-space-inside': 'never-single-line',
     'function-whitespace-after': 'always',
-    // indentation: 2,
-    // 'length-zero-no-unit': true,
+    indentation: 2,
+    'length-zero-no-unit': true,
     // 'max-empty-lines': 1,
     'media-feature-colon-space-after': 'always',
     'media-feature-colon-space-before': 'never',
@@ -72,31 +73,31 @@ module.exports = {
     'media-query-list-comma-newline-after': 'always-multi-line',
     'media-query-list-comma-space-after': 'always-single-line',
     'media-query-list-comma-space-before': 'never',
-    // 'no-eol-whitespace': true,
-    // 'no-missing-end-of-source-newline': true,
-    // 'number-leading-zero': 'always',
-    // 'number-no-trailing-zeros': true,
+    'no-eol-whitespace': true,
+    'no-missing-end-of-source-newline': true,
+    'number-leading-zero': 'always',
+    'number-no-trailing-zeros': true,
     'property-case': 'lower',
-    // 'rule-empty-line-before': [
-    //   'always-multi-line',
-    //   {
-    //     except: ['first-nested'],
-    //     ignore: ['after-comment'],
-    //   },
-    // ],
+    'rule-empty-line-before': [
+      'always-multi-line',
+      {
+        except: ['first-nested'],
+        ignore: ['after-comment'],
+      },
+    ],
     'selector-attribute-brackets-space-inside': 'never',
     'selector-attribute-operator-space-after': 'never',
     'selector-attribute-operator-space-before': 'never',
     'selector-combinator-space-after': 'always',
     'selector-combinator-space-before': 'always',
     'selector-descendant-combinator-no-non-space': true,
-    // 'selector-list-comma-newline-after': 'always',
+    'selector-list-comma-newline-after': 'always',
     'selector-list-comma-space-before': 'never',
     'selector-max-empty-lines': 0,
     'selector-pseudo-class-case': 'lower',
     'selector-pseudo-class-parentheses-space-inside': 'never',
     'selector-pseudo-element-case': 'lower',
-    // 'selector-pseudo-element-colon-notation': 'double',
+    'selector-pseudo-element-colon-notation': 'double',
     'selector-type-case': 'lower',
     'unit-case': 'lower',
     // 'value-keyword-case': 'lower',
@@ -106,6 +107,7 @@ module.exports = {
     'value-list-max-empty-lines': 0,
 
     // custom rules
+
     // 'color-named': 'never',
     // 'font-family-name-quotes': 'always-where-recommended',
     // 'font-weight-notation': 'numeric',

diff --git a/ui/app/components/app/account-menu/index.scss b/ui/app/components/app/account-menu/index.scss
@@ -82,7 +82,7 @@
       background-color: $dusty-gray;
       color: $black;
       font-weight: normal;
-      letter-spacing: .5px;
+      letter-spacing: 0.5px;
     }
   }
 
@@ -176,7 +176,7 @@
     background: #3f3f3f;
     z-index: 201;
     cursor: pointer;
-    opacity: .8;
+    opacity: 0.8;
     display: flex;
     justify-content: center;
     align-items: center;

diff --git a/ui/app/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss b/ui/app/components/app/alerts/unconnected-account-alert/unconnected-account-alert.scss
@@ -17,7 +17,7 @@
   }
 
   &__dismiss-button {
-    background: #037DD6;
+    background: #037dd6;
     color: white;
     height: 40px;
     width: 100px;
@@ -29,8 +29,8 @@
     margin-bottom: 16px;
     padding: 16px;
     font-size: 14px;
-    border: 1px solid #D73A49;
-    background: #F8EAE8;
+    border: 1px solid #d73a49;
+    background: #f8eae8;
     border-radius: 3px;
   }
 

diff --git a/ui/app/components/app/app-header/index.scss b/ui/app/components/app/app-header/index.scss
@@ -32,6 +32,7 @@
   &__metafox-logo {
     &--icon {
       height: 32px;
+
       @media screen and (min-width: $break-large) {
         display: none;
       }

diff --git a/ui/app/components/app/confirm-page-container/confirm-detail-row/index.scss b/ui/app/components/app/confirm-page-container/confirm-detail-row/index.scss
@@ -6,7 +6,7 @@
   align-items: center;
 
   &__label {
-    font-size: .75rem;
+    font-size: 0.75rem;
     font-weight: 500;
     color: $scorpion;
     text-transform: uppercase;
@@ -29,7 +29,7 @@
   }
 
   &__header-text {
-    font-size: .75rem;
+    font-size: 0.75rem;
     text-transform: uppercase;
     margin-bottom: 6px;
     color: $scorpion;
@@ -40,7 +40,7 @@
     }
 
     &--total {
-      font-size: .625rem;
+      font-size: 0.625rem;
     }
   }
 

diff --git a/...m-page-container/confirm-page-container-content/confirm-page-container-summary/index.scss b/...m-page-container/confirm-page-container-content/confirm-page-container-summary/index.scss
@@ -12,7 +12,7 @@
   &__action {
     text-transform: uppercase;
     color: $oslo-gray;
-    font-size: .75rem;
+    font-size: 0.75rem;
     padding: 3px 8px;
     border: 1px solid $oslo-gray;
     border-radius: 4px;

diff --git a/...m-page-container/confirm-page-container-content/confirm-page-container-warning/index.scss b/...m-page-container/confirm-page-container-content/confirm-page-container-warning/index.scss
@@ -12,7 +12,7 @@
   }
 
   &__warning {
-    font-size: .75rem;
+    font-size: 0.75rem;
     color: #5f5922;
   }
 }
diff --git a/ui/app/components/app/confirm-page-container/confirm-page-container-content/index.scss b/ui/app/components/app/confirm-page-container/confirm-page-container-content/index.scss
@@ -1,5 +1,4 @@
 @import 'confirm-page-container-warning/index';
-
 @import 'confirm-page-container-summary/index';
 
 .confirm-page-container-content {
@@ -17,14 +16,14 @@
   }
 
   &__data {
-   padding: 16px;
-   color: $oslo-gray;
+    padding: 16px;
+    color: $oslo-gray;
   }
 
   &__data-box {
     background-color: #f9fafa;
     padding: 12px;
-    font-size: .75rem;
+    font-size: 0.75rem;
     margin-bottom: 16px;
     word-wrap: break-word;
     max-height: 200px;
@@ -60,16 +59,16 @@
   }
 
   &__function-type {
-    font-size: .875rem;
+    font-size: 0.875rem;
     font-weight: 500;
     text-transform: capitalize;
     color: $black;
     padding-left: 5px;
   }
 
   &__tab {
-    font-size: .75rem;
-    color: #8C8E94;
+    font-size: 0.75rem;
+    color: #8c8e94;
     text-transform: uppercase;
     margin: 0 8px;
   }

diff --git a/ui/app/components/app/confirm-page-container/confirm-page-container-navigation/index.scss b/ui/app/components/app/confirm-page-container/confirm-page-container-navigation/index.scss
@@ -16,19 +16,19 @@
     padding-left: 5px;
     padding-right: 5px;
   }
-  
+
   &__arrow:hover {
     -webkit-transform: scale(1.1);
-      -moz-transform: scale(1.1);
-        -o-transform: scale(1.1);
-          transform: scale(1.1); 
+    -moz-transform: scale(1.1);
+    -o-transform: scale(1.1);
+    transform: scale(1.1);
   }
 
   &__arrow:active {
     -webkit-transform: scale(0.95);
-      -moz-transform: scale(0.95);
-        -o-transform: scale(0.95);
-          transform: scale(0.95); 
+    -moz-transform: scale(0.95);
+    -o-transform: scale(0.95);
+    transform: scale(0.95);
   }
 
   &__textcontainer {
@@ -47,8 +47,8 @@
 
   &__imageflip {
     -webkit-transform: scaleX(-1);
-      -moz-transform: scaleX(-1);
-        -o-transform: scaleX(-1);
-          transform: scaleX(-1);
+    -moz-transform: scaleX(-1);
+    -o-transform: scaleX(-1);
+    transform: scaleX(-1);
   }
-}
+}
diff --git a/ui/app/components/app/confirm-page-container/index.scss b/ui/app/components/app/confirm-page-container/index.scss
@@ -1,9 +1,6 @@
 @import 'confirm-page-container-content/index';
-
 @import 'confirm-page-container-header/index';
-
 @import 'confirm-detail-row/index';
-
 @import 'confirm-page-container-navigation/index';
 
 .page-container {

diff --git a/ui/app/components/app/connected-accounts-list/index.scss b/ui/app/components/app/connected-accounts-list/index.scss
@@ -22,15 +22,18 @@
 
   &__account-status {
     @extend %account-status-typography;
+
     display: inline;
     color: $Grey-500;
   }
 
   &__account-status-link {
     @extend %account-status-typography;
+
     display: block;
 
-    &, &:hover {
+    &,
+    &:hover {
       color: $curious-blue;
       cursor: pointer;
     }
@@ -43,17 +46,15 @@
     align-items: center;
     width: 100%;
     padding: 16px 24px;
-
     border-top: 1px solid $geyser;
 
     &--highlight {
       background-color: $warning-light-yellow;
       border: 1px solid $warning-yellow;
-
       box-sizing: border-box;
       padding: 16px;
       margin-bottom: 16px;
-      width: calc(100% - 16px)
+      width: calc(100% - 16px);
     }
   }