fix: flaky test `Navigation Signature - Different signature types ini…

…tiates multiple signatures and rejects all` (#27481)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
There is a delay for waiting the signatures to be queued, which
sometimes is not enough. In this fix, we remove the delay and we add
conditions to wait for (each new signature is added in the navigation),
so the behaviour is deterministic.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27481?quickstart=1)

## **Related issues**

Fixes: #27480

## **Manual testing steps**

1. Check ci
2. Run test locally `yarn test:e2e:single
test/e2e/tests/confirmations/navigation.spec.ts --browser=chrome
--leave-running=true`

## **Screenshots/Recordings**

See how the last signature is not properly queued, so in the last screen
we don't see the navigation. We should wait on each new signature to be
added in the navigation queue, before adding a new one


https://github.com/user-attachments/assets/4637fb21-aeb5-4b4f-b2c2-b03b349211a1



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

test/e2e/tests/confirmations/navigation.spec.ts

@@ -1,12 +1,12 @@
 import { strict as assert } from 'assert';
 import { TransactionEnvelopeType } from '@metamask/transaction-controller';
 import { Suite } from 'mocha';
+import { By } from 'selenium-webdriver';
 import {
   DAPP_HOST_ADDRESS,
-  WINDOW_TITLES,
   openDapp,
-  regularDelayMs,
   unlockWallet,
+  WINDOW_TITLES,
 } from '../../helpers';
 import { Driver } from '../../webdriver/driver';
 import { withRedesignConfirmationFixtures } from './helpers';
@@ -98,7 +98,6 @@ describe('Navigation Signature - Different signature types', function (this: Sui
         await unlockWallet(driver);
         await openDapp(driver);
         await queueSignatures(driver);
-        await driver.delay(regularDelayMs);
 
         await driver.clickElement('[data-testid="confirm-nav__reject-all"]');
 
@@ -166,11 +165,13 @@ async function queueSignatures(driver: Driver) {
   await driver.waitUntilXWindowHandles(3);
   await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
   await driver.findElement({ text: 'Reject all' });
+  await driver.waitForSelector(By.xpath("//div[normalize-space(.)='1 of 2']"));
 
   await driver.switchToWindowWithTitle(WINDOW_TITLES.TestDApp);
   await driver.clickElement('#signTypedDataV4');
   await driver.waitUntilXWindowHandles(3);
   await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
+  await driver.waitForSelector(By.xpath("//div[normalize-space(.)='1 of 3']"));
 }
 
 async function queueSignaturesAndTransactions(driver: Driver) {