Skip to content

Commit

Permalink
fix: fix reading address from market data (#27604)
Browse files Browse the repository at this point in the history
## **Description**

This PR fixes error when tokensMarketData sometimes resolves with a
small delay which will result in an app error;


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27604?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Switch networks back and forth and you should not see the app crash

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
sahar-fehri authored Oct 4, 2024
1 parent 5790f85 commit b10ffa6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const AggregatedPercentageOverview = () => {
// This is a regular ERC20 token
// find the relevant pricePercentChange1d in tokensMarketData
// Find the corresponding market data for the token by filtering the values of the tokensMarketData object
const found = tokensMarketData[toChecksumAddress(item.address)];
const found = tokensMarketData?.[toChecksumAddress(item.address)];

const tokenFiat1dAgo = getCalculatedTokenAmount1dAgo(
item.fiatBalance,
Expand Down

0 comments on commit b10ffa6

Please sign in to comment.