Skip to content

Commit

Permalink
Merge pull request #6759 from Gudahtt/node-v10
Browse files Browse the repository at this point in the history
Update to Node.js v10
  • Loading branch information
danfinlay authored Jun 27, 2019
2 parents d566543 + 9ed6456 commit 90eb5c4
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 31 deletions.
32 changes: 16 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ workflows:
jobs:
prep-deps-npm:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- run:
Expand All @@ -94,7 +94,7 @@ jobs:

prep-build:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -113,7 +113,7 @@ jobs:

prep-docs:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -128,7 +128,7 @@ jobs:

prep-scss:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -147,7 +147,7 @@ jobs:

test-lint:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -158,7 +158,7 @@ jobs:

test-deps:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -182,7 +182,7 @@ jobs:
# destination: test-artifacts
test-e2e-chrome:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -197,7 +197,7 @@ jobs:

test-e2e-firefox:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- run:
Expand All @@ -215,7 +215,7 @@ jobs:

job-screens:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -230,7 +230,7 @@ jobs:

job-publish-prerelease:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -250,7 +250,7 @@ jobs:

job-publish-release:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -267,7 +267,7 @@ jobs:
test-unit:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -277,7 +277,7 @@ jobs:
command: npm run test:coverage
test-mozilla-lint:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -288,7 +288,7 @@ jobs:

test-integration-flat-firefox:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -304,7 +304,7 @@ jobs:
environment:
browsers: '["Chrome"]'
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
Expand All @@ -315,7 +315,7 @@ jobs:

all-tests-pass:
docker:
- image: circleci/node:8.16-browsers
- image: circleci/node:10.16-browsers
steps:
- run:
name: All Tests Passed
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.16
v10.16.0
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ To learn how to contribute to the MetaMask project itself, visit our [Internal D

## Building locally

- Install [Node.js](https://nodejs.org) version 8 and the latest available npm@6
- Install [Node.js](https://nodejs.org) version 10 and the latest available npm@6
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you.
- If you install Node.js manually, ensure you're using npm@6
- Install npm@6 using `npm install -g npm@6`
Expand Down
24 changes: 11 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 90eb5c4

Please sign in to comment.