Shallow clone state before updating to avoid mutation

MetaMask · May 8, 2020 · 82fec4f · 82fec4f
1 parent e9bb114
commit 82fec4f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/scripts/controllers/alert.js b/app/scripts/controllers/alert.js
@@ -46,7 +46,8 @@ export default class AlertController {
   }
 
   setAlertEnabledness (alertId, enabledness) {
-    const { alertEnabledness } = this.store.getState()
+    let { alertEnabledness } = this.store.getState()
+    alertEnabledness = { ...alertEnabledness }
     alertEnabledness[alertId] = enabledness
     this.store.updateState({ alertEnabledness })
   }