Skip to content

Commit

Permalink
Fix alert disabling type error
Browse files Browse the repository at this point in the history
When disabling an alert, the background `alertEnabledness` state of the
alert was being set to `undefined` instead of `false`. This didn't have
any user-facing effect, since `undefined` is falsey, but it did result
in a PropType error on the Alert settings page. This mistake was made
in #8550.

The `alertEnabledness` state is now correctly set to `false` instead of
`undefined`.
  • Loading branch information
Gudahtt committed May 9, 2020
1 parent c4fb514 commit 559b187
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/app/ducks/alerts/unconnected-account.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const dismissAndDisableAlert = () => {
return async (dispatch) => {
try {
await dispatch(disableAlertRequested())
await dispatch(setAlertEnabledness(name), false)
await dispatch(setAlertEnabledness(name, false))
await dispatch(disableAlertSucceeded())
} catch (error) {
console.error(error)
Expand Down

0 comments on commit 559b187

Please sign in to comment.