Skip to content

Commit

Permalink
fix: content dialog styling is being applied to all dialogs (#28739)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Problem: A scss change for preventing modal scrolling in the bridge
experience was added and got unintentionally applied to all modals.

Solution: Nest the styling within the `quotes-modal` className
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28739?quickstart=1)

## **Related issues**

Fixes: #28722

## **Manual testing steps**

1. Visually inspect Swap token picker
2. Visually inspect tx "Speed up" and "Cancel" layout

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
See bug report screenshots

<!-- [screenshots/recordings] -->

### **After**
![Screenshot 2024-11-26 at 9 48
13 AM](https://github.com/user-attachments/assets/f5bd07d5-f062-4489-8c11-5e64f88eed75)


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
micaelae authored Nov 26, 2024
1 parent 86d6c05 commit 3f574c4
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions ui/pages/bridge/quotes/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@
}
}

.mm-modal-content__dialog {
display: flex;
height: 100%;
.quotes-modal {
.mm-modal-content__dialog {
display: flex;
height: 100%;
}
}

0 comments on commit 3f574c4

Please sign in to comment.