Permission System 2.0 (#12243)

# Permission System 2.0

## Background

This PR migrates the extension permission system to [the new `PermissionController`](https://github.com/MetaMask/snaps-skunkworks/tree/main/packages/controllers/src/permissions).
The original permission system, based on [`rpc-cap`](https://github.com/MetaMask/rpc-cap), introduced [`ZCAP-LD`](https://w3c-ccg.github.io/zcap-ld/)-like permissions to our JSON-RPC stack.
We used it to [implement](#7004) what we called "LoginPerSite" in [version 7.7.0](https://github.com/MetaMask/metamask-extension/releases/tag/v7.7.0) of the extension, which enabled the user to choose which accounts, if any, should be exposed to each dapp.
While that was a worthwhile feature in and of itself, we wanted a permission _system_ in order to enable everything we are going to with Snaps.
Unfortunately, the original permission system was difficult to use, and necessitated the creation of the original `PermissionsController` (note the "s"), which was more or less a wrapper for `rpc-cap`.

With this PR, we shake off the yoke of the original permission system, in favor of the modular, self-contained, ergonomic, and more mature permission system 2.0.

Note that [the `PermissionController` readme](https://github.com/MetaMask/snaps-skunkworks/tree/main/packages/controllers/src/permissions/README.md) explains how the new permission system works.

The `PermissionController` and `SubjectMetadataController` are currently shipped via `@metamask/snap-controllers`. This is a temporary state of affairs, and we'll move them to `@metamask/controllers` once they've landed in prod.

## Changes in Detail

First, the changes in this PR are not as big as they seem. Roughly half of the additions in this PR are fixtures in the test for the new migration (number 68), and a significant portion of the remaining ~2500 lines are due to find-and-replace changes in other test fixtures and UI files.

- The extension `PermissionsController` has been deleted, and completely replaced with the new `PermissionController` from [`@metamask/snap-controllers`](https://www.npmjs.com/package/@metamask/snap-controllers).
- The original `PermissionsController` "domain metadata" functionality is now managed by the new `SubjectMetadataController`, also from [`@metamask/snap-controllers`](https://www.npmjs.com/package/@metamask/snap-controllers).
- The permission activity and history log controller has been renamed `PermissionLogController` and has its own top-level state key, but is otherwise functionally equivalent to the existing implementation.
- Migration number 68 has been added to account for the new state changes.
- The tests in `app/scripts/controllers/permissions` have been migrated from `mocha` to `jest`.

Reviewers should focus their attention on the following files:

- `app/scripts/`
  - `metamask-controller.js`
    - This is where most of the integration work for the new `PermissionController` occurs.
      Some functions that were internal to the original controller were moved here.
  - `controllers/permissions/`
    - `selectors.js`
      - These selectors are for `ControllerMessenger` selector subscriptions. The actual subscriptions occur in `metamask-controller.js`. See the `ControllerMessenger` implementation for details.
    - `specifications.js`
      - The caveat and permission specifications are required by the new `PermissionController`, and are used to specify the `eth_accounts` permission and its JSON-RPC method implementation.
        See the `PermissionController` readme for details.
  - `migrations/068.js`
    - The new state should be cross-referenced with the controllers that manage it.
      The accompanying tests should also be thoroughly reviewed.

Some files may appear new but have just moved and/or been renamed:

- `app/scripts/lib/rpc-method-middleware/handlers/request-accounts.js`
  - This was previously implemented in `controllers/permissions/permissionsMethodMiddleware.js`.
- `test/mocks/permissions.js`
  - A truncated version of `test/mocks/permission-controller.js`.

Co-authored-by: Mark Stacey <[email protected]>

.circleci/config.yml

@@ -660,8 +660,8 @@ jobs:
       - attach_workspace:
           at: .
       - run:
-          name: test:coverage
-          command: yarn test:coverage
+          name: test:coverage:mocha
+          command: yarn test:coverage:mocha
       - run:
           name: test:coverage:jest
           command: yarn test:coverage:jest

.eslintrc.js

@@ -22,6 +22,7 @@ module.exports = {
 
   ignorePatterns: [
     '!.eslintrc.js',
+    '!.mocharc.js',
     'node_modules/**',
     'dist/**',
     'builds/**',
@@ -136,9 +137,10 @@ module.exports = {
         'ui/__mocks__/*.js',
         'shared/**/*.test.js',
         'development/**/*.test.js',
+        'app/scripts/lib/**/*.test.js',
         'app/scripts/migrations/*.test.js',
         'app/scripts/platforms/*.test.js',
-        'app/scripts/lib/**/*.test.js',
+        'app/scripts/controllers/permissions/*.test.js',
       ],
       extends: ['@metamask/eslint-config-mocha'],
       rules: {
@@ -161,9 +163,10 @@ module.exports = {
         'ui/__mocks__/*.js',
         'shared/**/*.test.js',
         'development/**/*.test.js',
+        'app/scripts/lib/**/*.test.js',
         'app/scripts/migrations/*.test.js',
         'app/scripts/platforms/*.test.js',
-        'app/scripts/lib/**/*.test.js',
+        'app/scripts/controllers/permissions/*.test.js',
       ],
       extends: ['@metamask/eslint-config-jest'],
       rules: {
@@ -186,7 +189,9 @@ module.exports = {
     {
       files: [
         '.eslintrc.js',
+        '.mocharc.js',
         'babel.config.js',
+        'jest.config.js',
         'nyc.config.js',
         'stylelint.config.js',
         'app/scripts/lockdown-run.js',
@@ -197,7 +202,6 @@ module.exports = {
         'test/setup.js',
         'test/helpers/protect-intrinsics-helpers.js',
         'test/lib/wait-until-called.js',
-        'jest.config.js',
       ],
       parserOptions: {
         sourceType: 'script',

.mocharc.js

@@ -2,10 +2,11 @@ module.exports = {
   // TODO: Remove the `exit` setting, it can hide broken tests.
   exit: true,
   ignore: [
+    './app/scripts/lib/**/*.test.js',
     './app/scripts/migrations/*.test.js',
     './app/scripts/platforms/*.test.js',
-    './app/scripts/lib/**/*.test.js',
+    './app/scripts/controllers/permissions/*.test.js',
   ],
   recursive: true,
   require: ['test/env.js', 'test/setup.js'],
-}
+};

.storybook/initial-states/approval-screens/token-approval.js

@@ -46,7 +46,7 @@ export const currentNetworkTxListSample = {
   ]
 }
 
-export const domainMetadata = {
+export const subjectMetadata = {
   "https://metamask.github.io": {
     "name": "E2E Test Dapp",
     "icon": "https://metamask.github.io/test-dapp/metamask-fox.svg",

.storybook/test-data.js

@@ -1013,34 +1013,25 @@ const state = {
       goerli: null,
       mainnet: 10902989,
     },
-    permissionsRequests: [],
-    permissionsDescriptions: {},
-    domains: {
+    subjects: {
       'https://app.uniswap.org': {
-        permissions: [
-          {
-            '@context': ['https://github.com/MetaMask/rpc-cap'],
+        permissions: {
+          'eth_accounts': {
             invoker: 'https://app.uniswap.org',
             parentCapability: 'eth_accounts',
             id: 'a7342e4b-beae-4525-a36c-c0635fd03359',
             date: 1620710693178,
             caveats: [
               {
-                type: 'limitResponseLength',
-                value: 1,
-                name: 'primaryAccountOnly',
-              },
-              {
-                type: 'filterResponse',
+                type: 'restrictReturnedAccounts',
                 value: ['0x64a845a5b02460acf8a3d84503b0d68d028b4bb4'],
-                name: 'exposedAccounts',
               },
             ],
           },
-        ],
+        },
       },
     },
-    permissionsLog: [
+    permissionActivityLog: [
       {
         id: 522690215,
         method: 'eth_accounts',
@@ -1171,7 +1162,7 @@ const state = {
         success: true,
       },
     ],
-    permissionsHistory: {
+    permissionHistory: {
       'https://metamask.github.io': {
         eth_accounts: {
           lastApproved: 1620710693213,
@@ -1181,7 +1172,7 @@ const state = {
         },
       },
     },
-    domainMetadata: {
+    subjectMetadata: {
       'https://metamask.github.io': {
         name: 'E2E Test Dapp',
         icon: 'https://metamask.github.io/test-dapp/metamask-fox.svg',

app/scripts/background.js

@@ -533,13 +533,8 @@ function setupController(initState, initLangCode) {
         ),
       );
 
-    // We're specifcally avoid using approvalController directly for better
-    // Error support during rejection
-    Object.keys(
-      controller.permissionsController.approvals.state.pendingApprovals,
-    ).forEach((approvalId) =>
-      controller.permissionsController.rejectPermissionsRequest(approvalId),
-    );
+    // Finally, reject all approvals managed by the ApprovalController
+    controller.approvalController.clear();
 
     updateBadge();
   }

app/scripts/controllers/permissions/background-api.js

@@ -0,0 +1,71 @@
+import {
+  CaveatTypes,
+  RestrictedMethods,
+} from '../../../../shared/constants/permissions';
+
+export function getPermissionBackgroundApiMethods(permissionController) {
+  return {
+    addPermittedAccount: (origin, account) => {
+      const existing = permissionController.getCaveat(
+        origin,
+        RestrictedMethods.eth_accounts,
+        CaveatTypes.restrictReturnedAccounts,
+      );
+
+      if (existing.value.includes(account)) {
+        throw new Error(
+          `eth_accounts permission for origin "${origin}" already permits account "${account}".`,
+        );
+      }
+
+      permissionController.updateCaveat(
+        origin,
+        RestrictedMethods.eth_accounts,
+        CaveatTypes.restrictReturnedAccounts,
+        [...existing.value, account],
+      );
+    },
+
+    removePermittedAccount: (origin, account) => {
+      const existing = permissionController.getCaveat(
+        origin,
+        RestrictedMethods.eth_accounts,
+        CaveatTypes.restrictReturnedAccounts,
+      );
+
+      if (!existing.value.includes(account)) {
+        throw new Error(
+          `eth_accounts permission for origin "${origin}" already does not permit account "${account}".`,
+        );
+      }
+
+      const remainingAccounts = existing.value.filter(
+        (existingAccount) => existingAccount !== account,
+      );
+
+      if (remainingAccounts.length === 0) {
+        permissionController.revokePermission(
+          origin,
+          RestrictedMethods.eth_accounts,
+        );
+      } else {
+        permissionController.updateCaveat(
+          origin,
+          RestrictedMethods.eth_accounts,
+          CaveatTypes.restrictReturnedAccounts,
+          remainingAccounts,
+        );
+      }
+    },
+
+    requestAccountsPermissionWithId: async (origin) => {
+      const [, { id }] = await permissionController.requestPermissions(
+        { origin },
+        {
+          eth_accounts: {},
+        },
+      );
+      return id;
+    },
+  };
+}