Prevent advanced gas input arrows from setting value to < 0

MetaMask · Mar 6, 2019 · 1296bcc · 1296bcc
1 parent dc79456
commit 1296bcc
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/ui/app/components/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js b/ui/app/components/gas-customization/advanced-gas-inputs/advanced-gas-inputs.component.js
@@ -80,8 +80,18 @@ export default class AdvancedTabContent extends Component {
           'advanced-gas-inputs__gas-edit-row__input--error': isInError && errorType === 'error',
           'advanced-gas-inputs__gas-edit-row__input--warning': isInError && errorType === 'warning',
         })}>
-          <div className="advanced-gas-inputs__gas-edit-row__input-arrows__i-wrap" onClick={() => onChange(value + 1)}><i className="fa fa-sm fa-angle-up" /></div>
-          <div className="advanced-gas-inputs__gas-edit-row__input-arrows__i-wrap" onClick={() => onChange(value - 1)}><i className="fa fa-sm fa-angle-down" /></div>
+          <div
+            className="advanced-gas-inputs__gas-edit-row__input-arrows__i-wrap"
+            onClick={() => onChange(value + 1)}
+          >
+            <i className="fa fa-sm fa-angle-up" />
+          </div>
+          <div
+            className="advanced-gas-inputs__gas-edit-row__input-arrows__i-wrap"
+            onClick={() => onChange(Math.max(value - 1, 0))}
+          >
+            <i className="fa fa-sm fa-angle-down" />
+          </div>
         </div>
         { isInError
           ? <div className={`advanced-gas-inputs__gas-edit-row__${errorType}-text`}>

diff --git a/...omization/gas-modal-page-container/advanced-tab-content/advanced-tab-content.component.js b/...omization/gas-modal-page-container/advanced-tab-content/advanced-tab-content.component.js
@@ -88,8 +88,18 @@ export default class AdvancedTabContent extends Component {
           'advanced-tab__gas-edit-row__input--error': isInError && errorType === 'error',
           'advanced-tab__gas-edit-row__input--warning': isInError && errorType === 'warning',
         })}>
-          <div className="advanced-tab__gas-edit-row__input-arrows__i-wrap" onClick={() => onChange(value + 1)}><i className="fa fa-sm fa-angle-up" /></div>
-          <div className="advanced-tab__gas-edit-row__input-arrows__i-wrap" onClick={() => onChange(value - 1)}><i className="fa fa-sm fa-angle-down" /></div>
+          <div
+            className="advanced-tab__gas-edit-row__input-arrows__i-wrap"
+            onClick={() => onChange(value + 1)}
+          >
+            <i className="fa fa-sm fa-angle-up" />
+          </div>
+          <div
+            className="advanced-tab__gas-edit-row__input-arrows__i-wrap"
+            onClick={() => onChange(Math.max(value - 1, 0))}
+          >
+            <i className="fa fa-sm fa-angle-down" />
+          </div>
         </div>
         { isInError
           ? <div className={`advanced-tab__gas-edit-row__${errorType}-text`}>