Fix phishing detect script (#7287)

MetaMask · Oct 18, 2019 · 06536b1 · 06536b1
1 parent a646bfb
commit 06536b1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/scripts/lib/util.js b/app/scripts/lib/util.js
@@ -38,7 +38,7 @@ const getEnvironmentType = (url = window.location.href) => {
   const parsedUrl = new URL(url)
   if (parsedUrl.pathname === '/popup.html') {
     return ENVIRONMENT_TYPE_POPUP
-  } else if (parsedUrl.pathname === '/home.html') {
+  } else if (['/home.html', '/phishing.html'].includes(parsedUrl.pathname)) {
     return ENVIRONMENT_TYPE_FULLSCREEN
   } else if (parsedUrl.pathname === '/notification.html') {
     return ENVIRONMENT_TYPE_NOTIFICATION

diff --git a/test/unit/app/util-test.js b/test/unit/app/util-test.js
@@ -18,11 +18,16 @@ describe('getEnvironmentType', function () {
     assert.equal(environmentType, ENVIRONMENT_TYPE_NOTIFICATION)
   })
 
-  it('should return fullscreen type', function () {
+  it('should return fullscreen type for home.html', function () {
     const environmentType = getEnvironmentType('http://extension-id/home.html')
     assert.equal(environmentType, ENVIRONMENT_TYPE_FULLSCREEN)
   })
 
+  it('should return fullscreen type for phishing.html', function () {
+    const environmentType = getEnvironmentType('http://extension-id/phishing.html')
+    assert.equal(environmentType, ENVIRONMENT_TYPE_FULLSCREEN)
+  })
+
   it('should return background type', function () {
     const environmentType = getEnvironmentType('http://extension-id/_generated_background_page.html')
     assert.equal(environmentType, ENVIRONMENT_TYPE_BACKGROUND)