This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
refactor: make exportAccount, listRequests and getRequest optional
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async transaction flow shouldn't require snaps to implement the `listRequests` and `getRequest` methods, so we are making them optional. Also, the `exportAccount` may not be supported by all snaps, so it doesn't make sense to force it's implementation. We decided to keep the CRUD account management methods mandatory, since the are (or will be) directly called by MetaMask.
danroc
force-pushed
the
feature/make-some-methods-optional
branch
from
a606f4e
to
9dac9d7
Compare
danroc
requested review from
montelaidev,
gantunesr and
a team
and removed request for
gantunesr and
montelaidev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async transaction flow shouldn't require snaps to implement the
listRequestsandgetRequestmethods, so we are making them optional.Also, the
exportAccountmay not be supported by all snaps, so it doesn't make sense to force its implementation.We decided to keep the CRUD account management methods mandatory, since they are (or will be) directly called by MetaMask.