This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: make approveRequest and rejectRequest optional
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
force-pushed
the
feature/make-approve-reject-optional
branch
2 times, most recently
from
65735e3 to
c9b3461
Compare
danroc
force-pushed
the
feature/make-approve-reject-optional
branch
from
c9b3461 to
eed93ee
Compare
montelaidev
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
approveRequestandrejectRequestmethods optional in the Keyring API.Rationale: Keyrings that implement a synchonous signature flow don't require those methods to be implemented.