This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat!: add KeyringExecutionContext to user ops methods #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also have a |
danroc
added
team-accounts
|
That was my "end-goal plan" yes, but I wanted to keep it for another refactor later, but since those are new changes, I guess I can do that right now yes! |
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
3 times, most recently
from
9ed7afa
to
6d33fb2
Compare
ccharly
changed the title
2 tasks
danroc
reviewed
Mar 14, 2024
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
from
6d33fb2
to
01fbc9b
Compare
ccharly
changed the title
ccharly
force-pushed
the
feature/307/caip-2-user-ops
branch
from
01fbc9b
to
7273f96
Compare
danroc
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an additional parameter about the "execution context" (contains only
chainIdfor now) for User operations methods. This will also help computing the CAIP-2 scope/chain-id for underlying calls later on.Related to