This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
refactor: rename RPC handling functions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
force-pushed
the
feature/add-rpc-keyring-class
branch
from
07bea61
to
4f967ea
Compare
danroc
force-pushed
the
feature/add-rpc-keyring-class
branch
from
4425be0
to
d2634d1
Compare
It forces the redefinition of all `Keyring` methods in the abstract class, so it can be a source of errors in the future for no added value. Prefer the `handleKeyringRequest` function instead.
danroc
changed the title
BaseRpcKeyring class
montelaidev
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
BaseRpcKeyringabstract class that integrates adispatchmethod.