Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

refactor!: change the events' prefix to notify: #139

Merged
merged 1 commit into from
Oct 9, 2023
Merged

refactor!: change the events' prefix to notify: #139

merged 1 commit into from
Oct 9, 2023

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Oct 4, 2023

This is more in line with the fact that events are sent to the extension as an RPC call.

await snap.request({
  method: 'snap_manageAccounts',
  params: {
    method: 'notify:accountCreated',
    params: { account },
  },
});

BREAKING: This is a braking change, but users shouldn't be concerned since it only changes the enum values.

@danroc danroc requested a review from a team as a code owner October 4, 2023 20:31
@danroc danroc enabled auto-merge October 6, 2023 00:09
@danroc
refactor!: change the events' prefix to notify:
29577fd 
This is more in line with the fact that events are sent to the extension
as an RPC call.
@danroc danroc self-assigned this Oct 8, 2023
@danroc danroc added team-accounts This should be handled by the Accounts Team type-enhancement New feature or request high-priority High priority issues labels Oct 8, 2023
@danroc danroc added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 209b184 Oct 9, 2023
16 checks passed
@danroc danroc deleted the feature/rename-events branch October 9, 2023 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@montelaidev montelaidev montelaidev approved these changes

Assignees

@danroc danroc

Labels
high-priority High priority issues team-accounts This should be handled by the Accounts Team type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danroc @montelaidev