Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

chore(deps): update Snap and ESLint dependencies #117

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Sep 21, 2023

No description provided.

@danroc danroc requested a review from a team as a code owner September 21, 2023 19:39
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/snaps-controllers 2.0.0 eval, network, shell +13 7.29 MB metamaskbot
eslint-plugin-import 2.28.1...2.26.0 None +2/-51 1.12 MB ljharb

🚮 Removed packages: [email protected]

@socket-security
Copy link

socket-security bot commented Sep 22, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @metamask/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@danroc
Copy link
Contributor Author

danroc commented Sep 22, 2023

Concerning the rpc-controller "shell access" warning, it's used to spin a snap executor in a separate process (discussed with @FrederikBolding).

@danroc
Copy link
Contributor Author

danroc commented Sep 22, 2023

@SocketSecurity ignore @metamask/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @metamask/[email protected]

@danroc danroc enabled auto-merge (squash) September 22, 2023 10:51
Copy link
Contributor

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@danroc danroc merged commit 8dc5fba into main Sep 22, 2023
16 checks passed
@danroc danroc deleted the feature/update-deps branch September 22, 2023 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants