fix: update snap object keys to be mandatory and move name to metadata

MetaMask · Aug 30, 2023 · dfcf4d2 · dfcf4d2
1 parent 6c94e22
commit dfcf4d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/internal/types.test.ts b/src/internal/types.test.ts
@@ -14,6 +14,7 @@ describe('InternalAccount', () => {
         keyring: {
           type: 'Test Keyring',
         },
+        name: 'Account 1',
       },
     };
 
@@ -29,6 +30,7 @@ describe('InternalAccount', () => {
       type: 'eip155:eoa',
       metadata: {
         keyring: {},
+        name: 'Account 1',
       },
     };
 
@@ -44,7 +46,9 @@ describe('InternalAccount', () => {
       options: {},
       methods: [],
       type: 'eip155:eoa',
-      metadata: {},
+      metadata: {
+        name: 'Account 1',
+      },
     };
 
     expect(() => assert(account, InternalAccountStruct)).toThrow(
@@ -77,6 +81,7 @@ describe('InternalAccount', () => {
         keyring: {
           type: 'Test Keyring',
         },
+        name: 'Account 1',
         extra: 'field',
       },
     };

diff --git a/src/internal/types.ts b/src/internal/types.ts
@@ -7,11 +7,11 @@ export const InternalAccountStruct = object({
   metadata: object({
     snap: optional(
       object({
-        id: optional(string()),
-        name: optional(string()),
-        enabled: optional(boolean()),
+        id: string(),
+        enabled: boolean(),
       }),
     ),
+    name: string(),
     keyring: object({
       type: string(),
     }),