chore: make snap ID optional

MetaMask · Aug 4, 2023 · d94cfdc · d94cfdc
1 parent ef2831f
commit d94cfdc
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 7 deletions.
diff --git a/src/internal/types.test.ts b/src/internal/types.test.ts
@@ -20,23 +20,49 @@ describe('InternalAccount', () => {
     expect(() => assert(account, InternalAccountStruct)).not.toThrow();
   });
 
-  it('should throw if snap ID is missing', () => {
+  it('should throw if metadata.keyring.type is not set', () => {
     const account = {
       id: '606a7759-b0fb-48e4-9874-bab62ff8e7eb',
       address: '0x000',
       options: {},
       methods: [],
       type: 'eip155:eoa',
       metadata: {
-        snap: {},
-        keyring: {
-          type: 'Test Keyring',
-        },
+        keyring: {},
       },
     };
 
     expect(() => assert(account, InternalAccountStruct)).toThrow(
-      'At path: metadata.snap.id -- Expected a string, but received: undefined',
+      'At path: metadata.keyring.type -- Expected a string, but received: undefined',
+    );
+  });
+
+  it('should throw if metadata.keyring is not set', () => {
+    const account = {
+      id: '606a7759-b0fb-48e4-9874-bab62ff8e7eb',
+      address: '0x000',
+      options: {},
+      methods: [],
+      type: 'eip155:eoa',
+      metadata: {},
+    };
+
+    expect(() => assert(account, InternalAccountStruct)).toThrow(
+      'At path: metadata.keyring -- Expected an object, but received: undefined',
+    );
+  });
+
+  it('should throw if metadata is not set', () => {
+    const account = {
+      id: '606a7759-b0fb-48e4-9874-bab62ff8e7eb',
+      address: '0x000',
+      options: {},
+      methods: [],
+      type: 'eip155:eoa',
+    };
+
+    expect(() => assert(account, InternalAccountStruct)).toThrow(
+      'At path: metadata -- Expected an object, but received: undefined',
     );
   });
 

diff --git a/src/internal/types.ts b/src/internal/types.ts
@@ -7,7 +7,7 @@ export const InternalAccountStruct = object({
   metadata: object({
     snap: optional(
       object({
-        id: string(),
+        id: optional(string()),
         name: optional(string()),
         enabled: optional(boolean()),
       }),