Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Add runtime typecheck for request objects and return handlers, refactor _handle #70

Merged
merged 7 commits into from
Nov 19, 2020
Merged

Add runtime typecheck for request objects and return handlers, refactor _handle #70

merged 7 commits into from
Nov 19, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Nov 19, 2020 •
edited
Loading

  • Reject requests if:
    • They are not plain objects
    • request.method is not a string
    • next() is called with a non-function parameter during processing
  • Refactor internal method _handle to be async (stack traces may improve somewhat)
  • Add docstrings for public methods
  • Fix some formatting issues

@rekmarks rekmarks requested a review from brad-decker November 19, 2020 06:19
@rekmarks rekmarks requested a review from a team as a code owner November 19, 2020 06:19
@rekmarks rekmarks changed the title Add runtime typecheck for requests, refactor internals Add runtime typecheck for request objects, refactor internals Nov 19, 2020
@rekmarks rekmarks changed the title Add runtime typecheck for request objects, refactor internals Add runtime typecheck for request objects, refactor _handle Nov 19, 2020
@rekmarks rekmarks marked this pull request as draft November 19, 2020 08:10
@rekmarks rekmarks changed the title Add runtime typecheck for request objects, refactor _handle Add runtime typecheck for request objects and return handlers, refactor _handle Nov 19, 2020
@rekmarks rekmarks marked this pull request as ready for review November 19, 2020 16:42
brad-decker
brad-decker approved these changes Nov 19, 2020
View reviewed changes
Copy link

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot woot. LGTM

@rekmarks rekmarks merged commit f39f39d into main Nov 19, 2020
@rekmarks rekmarks deleted the async-first-_handle branch November 19, 2020 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brad-decker brad-decker brad-decker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @brad-decker